[devops] Don't clean ACES bots. by rolfbjarne · Pull Request #25646 · dotnet/macios

rolfbjarne · 2026-06-04T17:00:55Z

They're already clean.

Looks like this will save ~2 min for every job.

They're already clean. Looks like this will save ~2 min for every job.

rolfbjarne · 2026-06-04T17:01:15Z

/azp run

rolfbjarne · 2026-06-04T17:01:35Z

/azp run

azure-pipelines · 2026-06-04T17:01:44Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2026-06-04T17:01:51Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

This PR updates the DevOps macOS bot cleanup script to skip all cleanup work when running on “ACES” bots, based on the assumption those machines are already clean—intended to save ~2 minutes per job.

Changes:

Add an early exit in clean-bot.sh when the ACES environment variable is set, bypassing all cleanup steps.

+if [[ "$ACES" != "" ]]; then
+	echo "Assuming ACES bots are already clean, so not cleaning anything."
+	exit 0
+fi


dalexsoto · 2026-06-05T03:26:55Z

/azp run

azure-pipelines · 2026-06-05T03:27:23Z

Azure Pipelines successfully started running 3 pipeline(s).

rolfbjarne · 2026-06-05T08:30:45Z

/azp run

azure-pipelines · 2026-06-05T08:31:15Z

Azure Pipelines successfully started running 3 pipeline(s).

vs-mobiletools-engineering-service2 · 2026-06-05T08:46:17Z

✅ [PR Build #51cc2ba] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 51cc2ba532042e2771797f150bbbc179100579e1 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T08:53:15Z

✅ [PR Build #51cc2ba] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 51cc2ba532042e2771797f150bbbc179100579e1 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T08:58:35Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 51cc2ba532042e2771797f150bbbc179100579e1 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T09:08:07Z

✅ [PR Build #51cc2ba] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 51cc2ba532042e2771797f150bbbc179100579e1 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T18:06:46Z

🔥 [CI Build #51cc2ba] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 3 tests failed, 190 tests passed.

Failures

❌ introspection tests [attempt 3]

1 tests failed, 5 tests passed.

Failed tests

introspection/macOS/Debug: Failed (Test run failed.
Tests run: 34 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 0)

Html Report (VSDrops) Download

❌ monotouch tests (iOS) [attempt 3]

1 tests failed, 19 tests passed.

Failed tests

monotouch-test/iOS - simulator/Debug (LinkSdk): Failed

Html Report (VSDrops) Download

❌ Tests on macOS Monterey (12) tests

1 tests failed, 4 tests passed.

Failed tests

monotouch-test: Failed (exit code 2)
- No test failure details available. stderr output:
  - 2026-06-05 05:29:09.615 monotouchtest[36053:32633716] [PASS] VeryGeneric
  - 2026-06-05 05:29:09.616 monotouchtest[36053:32633716] [PASS] WrapperTypeLookupTest
  - 2026-06-05 05:29:09.616 monotouchtest[36053:32633716] Xamarin.Tests.RuntimeTest : 457.8342 ms
  - 2026-06-05 05:29:09.617 monotouchtest[36053:32633716] Xamarin.Tests : 457.8814 ms
  - 2026-06-05 05:29:09.617 monotouchtest[36053:32633716] Xamarin : 465.9933 ms
  - 2026-06-05 05:29:09.617 monotouchtest[36053:32633716] bindings-test : 466.0814 ms
  - 2026-06-05 05:29:09.622 monotouchtest[36053:32632920] Tests run: 3339 Passed: 3329 Inconclusive: 10 Failed: 0 Ignored: 431
  - 2026-06-05 05:29:09.622 monotouchtest[36053:32632920] AutoRun (): completed test run on main thread
  - 2026-06-05 05:29:09.623 monotouchtest[36053:32632920] Exiting test run with success
  - make: *** [exec-monotouch-test] Error 1

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 51cc2ba532042e2771797f150bbbc179100579e1 [PR build]

[devops] Don't clean ACES bots.

1886e84

They're already clean. Looks like this will save ~2 min for every job.

Copilot AI review requested due to automatic review settings June 4, 2026 17:00

rolfbjarne enabled auto-merge (squash) June 4, 2026 17:00

Copilot started reviewing on behalf of rolfbjarne June 4, 2026 17:01 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread tools/devops/automation/scripts/bash/clean-bot.sh

Comment on lines +9 to +12

if [[ "$ACES" != "" ]]; then

echo "Assuming ACES bots are already clean, so not cleaning anything."

exit 0

fi

dalexsoto approved these changes Jun 4, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/squeaky-clean

1dd9032

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/squeaky-clean

51cc2ba

This comment has been minimized.

Sign in to view

Conversation

rolfbjarne commented Jun 4, 2026

Uh oh!

rolfbjarne commented Jun 4, 2026

Uh oh!

rolfbjarne commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto commented Jun 5, 2026

Uh oh!

azure-pipelines Bot commented Jun 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 5, 2026

Uh oh!

azure-pipelines Bot commented Jun 5, 2026

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ [PR Build #51cc2ba] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ [PR Build #51cc2ba] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ [PR Build #51cc2ba] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 5, 2026

🔥 [CI Build #51cc2ba] Test results 🔥

Test results

Failures

❌ introspection tests [attempt 3]

Failed tests

❌ monotouch tests (iOS) [attempt 3]

Failed tests

❌ Tests on macOS Monterey (12) tests

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants