Skip to content

[dotnet] Put type-map.txt into the linker cache directory.#25654

Open
rolfbjarne wants to merge 2 commits into
mainfrom
dev/rolf/fix-type-map-location
Open

[dotnet] Put type-map.txt into the linker cache directory.#25654
rolfbjarne wants to merge 2 commits into
mainfrom
dev/rolf/fix-type-map-location

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jun 5, 2026

Copy link
Copy Markdown
Member

This way it's copied back to Windows automatically after a remote build.

rolfbjarne added 2 commits June 5, 2026 17:26
@rolfbjarne
[dotnet] Put type-map.txt into the linker cache directory.
8e0ebdf 
This way it's copied back to Windows automatically after a remote build.
@rolfbjarne
[dotnet] Reorder variable assignment a bit.
8a366a5
Copilot AI review requested due to automatic review settings June 5, 2026 15:27
@rolfbjarne

rolfbjarne commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Jun 5, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .NET MSBuild targets so the generated type-map.txt is placed inside the linker cache directory, allowing it to be synchronized back to Windows automatically after a remote build.

Changes:

  • Move _LinkerCacheDirectory property initialization to _ComputeVariables.
  • Change the default _TypeMapFilePath from $(DeviceSpecificIntermediateOutputPath)type-map.txt to $(_LinkerCacheDirectory)/type-map.txt.

Comment thread dotnet/targets/Xamarin.Shared.Sdk.targets
Comment on lines 595 to 597
<!-- The directory where the linker puts *.items files that will be loaded in the _LoadLinkerOutput target -->
<_LinkerItemsDirectory>$([System.IO.Path]::GetFullPath('$(IntermediateOutputPath)linker-items'))</_LinkerItemsDirectory>
<_LinkerItemsDirectory Condition="'$(BuildSessionId)' != ''">$(IntermediateOutputPath)linker-items</_LinkerItemsDirectory>
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #8a366a5] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8a366a509641cd6597d64ff50a1ec51e00e279e2 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #8a366a5] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8a366a509641cd6597d64ff50a1ec51e00e279e2 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8a366a509641cd6597d64ff50a1ec51e00e279e2 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #8a366a5] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8a366a509641cd6597d64ff50a1ec51e00e279e2 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #8a366a5] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 19 tests failed, 174 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

Failed tests

  • DotNet tests: Failed (Execution failed with exit code 1)
    • Xamarin.Tests.AppIconTest.AlternateAppIcon(iOS,"ios-arm64"): 'dotnet build' failed with exit code 1
      Full command: /Users/builder/azdo/_work/1/s/macios/builds/downloads/dotnet-sdk-10.0.400-p...
    • Xamarin.Tests.AppIconTest.AlternateAppIcon(iOS,"iossimulator-x64...: 'dotnet build' failed with exit code 1
      Full command: /Users/builder/azdo/_work/1/s/macios/builds/downloads/dotnet-sdk-10.0.400-p...
    • Xamarin.Tests.AppIconTest.AlternateAppIcons(iOS,"ios-arm64"): 'dotnet build' failed with exit code 1
      Full command: /Users/builder/azdo/_work/1/s/macios/builds/downloads/dotnet-sdk-10.0.400-p...
    • ... and 56 more

Html Report (VSDrops) Download

❌ interdependent-binding-projects tests

2 tests failed, 2 tests passed.

Failed tests

  • interdependent-binding-projects/iOS - simulator/Debug: LaunchTimedOut
  • interdependent-binding-projects/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ linker tests (iOS)

11 tests failed, 0 tests passed.

Failed tests

  • dont link/iOS - simulator/Debug: LaunchTimedOut
  • dont link/iOS - simulator/Release: LaunchTimedOut
  • link sdk/iOS - simulator/Debug: LaunchTimedOut
  • link sdk/iOS - simulator/Release: LaunchTimedOut
  • link all/iOS - simulator/Debug: LaunchTimedOut
  • link all/iOS - simulator/Release: LaunchTimedOut
  • link all/iOS - simulator/Debug (don't bundle original resources): LaunchTimedOut
  • trimmode copy/iOS - simulator/Debug: LaunchTimedOut
  • trimmode copy/iOS - simulator/Release: LaunchTimedOut
  • trimmode link/iOS - simulator/Debug: LaunchTimedOut
  • trimmode link/iOS - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

1 tests failed, 19 tests passed.

Failed tests

  • monotouch-test/iOS - simulator/Release (trimmable static registrar, NativeAOT, ARM64): BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

1 tests failed, 22 tests passed.

Failed tests

  • monotouch-test/macOS/Debug (managed static registrar): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

❌ xcframework tests

2 tests failed, 2 tests passed.

Failed tests

  • xcframework-test/iOS - simulator/Debug: LaunchTimedOut
  • xcframework-test/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ Tests on macOS Monterey (12) tests

1 tests failed, 4 tests passed.

Failed tests

  • monotouch-test: Failed (exit code 2)
    • No test failure details available. stderr output:
      • 2026-06-05 12:33:10.989 monotouchtest[53156:32766518] [PASS] VeryGeneric
      • 2026-06-05 12:33:10.990 monotouchtest[53156:32766518] [PASS] WrapperTypeLookupTest
      • 2026-06-05 12:33:10.990 monotouchtest[53156:32766518] Xamarin.Tests.RuntimeTest : 475.8334 ms
      • 2026-06-05 12:33:10.990 monotouchtest[53156:32766518] Xamarin.Tests : 475.896 ms
      • 2026-06-05 12:33:10.990 monotouchtest[53156:32766518] Xamarin : 484.2845 ms
      • 2026-06-05 12:33:10.990 monotouchtest[53156:32766518] bindings-test : 484.3877 ms
      • 2026-06-05 12:33:10.996 monotouchtest[53156:32765618] Tests run: 3368 Passed: 3358 Inconclusive: 10 Failed: 0 Ignored: 402
      • 2026-06-05 12:33:10.996 monotouchtest[53156:32765618] AutoRun (): completed test run on main thread
      • 2026-06-05 12:33:10.996 monotouchtest[53156:32765618] Exiting test run with success
      • make: *** [exec-monotouch-test] Error 1

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 8a366a509641cd6597d64ff50a1ec51e00e279e2 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto