Enable fully qualified Helix test name reporting#55404
Draft
Evangelink wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a85f3e36-e8eb-468a-9902-f658dd9f1e62
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
| - template: /eng/common/core-templates/job/helix-job-monitor.yml@self | ||
| parameters: | ||
| helixAccessToken: $(HelixApiAccessToken) | ||
| useFullyQualifiedTestName: true |
Member
There was a problem hiding this comment.
Is there a reason this is not the default behavior?
Member
Author
There was a problem hiding this comment.
Just to avoid break in history for others. There was a request to make it default but I would like to make sure this is working well here first (I am quite new with Helix codebase so I couldn't find how to validate the fix with real E2E)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable fully qualified test name reporting for the Helix job monitor in both SDK PR and CI pipelines.
This avoids collisions when different test classes contain methods with the same name and gives Azure DevOps a stable fully qualified test identity.
Dependency
Blocked on the next Arcade/VMR backflow into SDK. The
useFullyQualifiedTestNametemplate parameter and corresponding JobMonitor support were added by dotnet/arcade#17104. That change is present in the current VMR, but the Arcade snapshot currently consumed by SDK predates it.The draft should remain unmerged until SDK's
eng/common/core-templates/job/helix-job-monitor.ymlandMicrosoft.DotNet.Helix.JobMonitordependency contain that change.Fixes the Helix reporting side of #55123.