improve sorting of installed versions when uninstalling dotnet version#2740
Open
nitheeshgovind wants to merge 1 commit into
Open
improve sorting of installed versions when uninstalling dotnet version#2740nitheeshgovind wants to merge 1 commit into
nitheeshgovind wants to merge 1 commit into
Conversation
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the command "Uninstall .NET" is selected, the displayed versions are not sorted based on the version numbers.
#2642
Root Cause
localeComparewas used which did not sort the numbers correctly.Changes
Added a new
compareVersionfunction which splits the version into integers and compares each index.I also thought about creating a new function in
VersionUtilitiesunder the runtime-library, but thought to check first.Let me know if it is ok.