Separate xUnit compatibility fix from Arcade update PR#5937
Open
imcarolwang wants to merge 1 commit intodotnet:mainfrom
Open
Separate xUnit compatibility fix from Arcade update PR#5937imcarolwang wants to merge 1 commit intodotnet:mainfrom
imcarolwang wants to merge 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the xUnit package compatibility fix from the Arcade dependency update PR (#5936).
The initial CI failure reported from dotnet-svcutil-lib.Tests.csproj:
NU1202: xunit.v3.assert.aot 3.2.2 is not compatible with net8.0Local reproduction showed additional xUnit conflicts affecting multiple test projects, this change fixes those issues separately to unblock the Arcade update PR.
Example:
error CS0433: The type 'Assert' exists in both 'xunit.assert, Version=2.9.3.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' and 'xunit.v3.assert.aot, Version=3.2.2.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c'