Add Raw View mode for improved performance with heavy USD files - #37
Open
ManuelCarullo wants to merge 1 commit into
Open
Add Raw View mode for improved performance with heavy USD files#37ManuelCarullo wants to merge 1 commit into
ManuelCarullo wants to merge 1 commit into
Conversation
* Add Raw View mode for improved performance - Use TextEditor instead of TextBrowser for Raw View mode to avoid HTML processing overhead. - Disable syntax highlighting and link parsing in Raw View - Add preference to default new tabs to Raw View mode * Update documentation and configuration - Add Raw View mode documentation to usage.md - Add Raw View shortcut (Ctrl+Shift+V) to keyboard shortcuts - Fix Sphinx configuration for Python 3 compatibility - Modernize conf.py with proper version import and theme Signed-off-by: Manuel Carullo <git@carullo.dev>
Collaborator
|
@ManuelCarullo Thanks for the update! It looks like we don't have a CLA for you. Could you sign the contributor agreement and email that to usdmanager@dreamworks.com? Thanks! |
Author
Oh right, totally forgot about that sorry. I just sent it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usdmanager can be very slow when opening heavy usd files with lots of data. This is still the case when syntax highlighting and link parsing is turned off.
I narrowed this down to the setHtml() call on the TextBrowser that is taking most of the time.
With this PR I suggest adding a Raw View mode, that uses the TextEditor in read only mode instead of the TextBrowser, which leads to significant performance improvements, when loading heavy usd files.
I'm not sure how actively this repo is still maintained, so sorry if this is the wrong place for the PR.
Also you can ignore the changes in docs/conf.py and docs/requirements.txt, just wanted to match my documentation build to the official one.