Fix documented action layout - #77
Open
sawhney17 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Correct the documented seven-value
actionlayout from six joint velocities plus gripper position to six commanded Cartesian-position values plus commanded gripper position.Evidence
The pinned dataset-builder implementation constructs
actionwith:See
droid.pylines 69–77. The same builder's feature documentation currently carries the joint-velocity wording, so the generatedfeatures.jsoninherited it.I also decoded all 100 episodes in the official
droid_100/1.0.0sample and compared every step. All 32,212/32,212actionvectors exactly equal the six-valueaction_dict.cartesian_positionconcatenated with the one-valueaction_dict.gripper_position; the maximum absolute difference is 0.actiondiffers fromaction_dict.joint_velocity(maximum absolute difference 4.125915944576263).The machine-readable audit, pinned object generations/checksums, and RFC 6902 metadata patch are published in
droid-quality-auditv0.1.0:Scope
This PR changes one documentation line only. It does not alter stored dataset values or claim that the action is Cartesian velocity.