fix: consume ios driver from core cli#353
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4632718fd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "llama-index-llms-openrouter>=0.4.2", | ||
| "mobilerun-sdk>=3.2.0", | ||
| "mobilerun-core-cli>=0.1.0", | ||
| "mobilerun-core-cli>=0.2.0", |
There was a problem hiding this comment.
When contributors use the committed uv.lock in locked/frozen installs, this new minimum is not applied: uv.lock still records mobilerun-core-cli metadata as >=0.1.0 and pins the package entry to version 0.1.0 (uv.lock lines 1905 and 1930-1931). That leaves locked environments using the old core CLI even though the shim now imports the iOS driver implementation from that package, so the iOS import path can fail or run an incompatible implementation until the lockfile is regenerated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed72fc4b0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "llama-index-llms-openrouter>=0.4.2", | ||
| "mobilerun-sdk>=3.2.0", | ||
| "mobilerun-core-cli>=0.1.0", | ||
| "mobilerun-core-cli>=0.2.0", |
There was a problem hiding this comment.
For installs that resolve from the default PyPI index, this new requirement makes the package uninstallable: PyPI currently lists mobilerun-core-cli only at 0.1.0 (https://pypi.org/pypi/mobilerun-core-cli/json), so mobilerun-core-cli>=0.2.0 has no matching distribution. Since the new iOS shim depends on symbols moved into that package, please either publish 0.2.0 before merging/releasing this change or depend on an available artifact/source that contains the iOS driver.
Useful? React with 👍 / 👎.
1 participant
No description provided.