Make the Timex build playable in the browser - #1
Merged
Conversation
The page said the hi-colour Timex build was not playable here because JSSpeccy has no Timex video modes. It does now: our fork adds the TC2048 and TC2068, so the dedicated build can run on the page it was written for instead of only being a download. Adds a machine switch - Spectrum 128K, Timex TC2048, Timex TC2068 - with the 128K build as the default, and builds both TAPs in the deploy. Stops vendoring the emulator. The committed copy under site/jsspeccy was a stock JSSpeccy build with no Timex support, so it had to be replaced either way; rather than commit another 440K of build output, the deploy now downloads a tagged release of dtz-labs/jsspeccy3 and unpacks it. Bump JSSPECCY_RELEASE in the workflow to move to a newer emulator. The deploy asserts the Timex ROMs, tape loaders and both TAPs are present before publishing, so an incomplete site fails the build rather than shipping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page said the hi-colour Timex build was not playable here because JSSpeccy has no Timex video modes. It does now — our fork adds the TC2048 and TC2068 — so the dedicated build can run on the page it was written for instead of only being a download.
make standard timex) and publishes both.site/jsspeccywas a stock JSSpeccy build with no Timex support, so it had to be replaced either way; rather than commit another 440K of build output, the deploy now downloads a tagged release of dtz-labs/jsspeccy3 and unpacks it. BumpJSSPECCY_RELEASEin the workflow to move to a newer emulator.