Minor Performance improvements#88
Merged
mrkpatchaa merged 37 commits intomainfrom Apr 23, 2026
Merged
Conversation
…d per-weight subpaths
- icon-base-single.tsx: lightweight IconBase with pre-resolved ReactElement paths
- generator: generateSingleWeightDef/Icon/AllSingleWeightDirs for src/<weight>/ dirs
- scripts/build-weights.mjs: compile each weight to lib/{module,commonjs,typescript}/<weight>/
- tests: lib-weight-subpaths.test.ts verifies all 6 weight outputs
- Rename 'Single' tab to 'Perf' - Section 1: React.memo demo — tap button to increment parent renders, icons with stable props skip re-renders (render count stays at 1) - Section 2: Per-weight subpath imports from /regular and /bold barrels - Section 3: Classic multi-weight import showing all 6 weight variants
…s in bundle-bench
…n plain-element defs
duongdev
approved these changes
Apr 22, 2026
refactor: remove esbuild dependency from package.json and yarn.lock
mrkpatchaa
changed the title
mrkpatchaa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #61
I tried sub path imports to import only specific weights of icons. But that was generating too many files. NPM even rejected the publish.
I added benchmark script to measure impact of different imports. Here are the results:
Follow this link to understand the experimental three shaking support from Expo.