Skip to content

force cache invalidation & forward custom headers #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maorhayoun wants to merge 3 commits into
base: master
Choose a base branch
from
Open

force cache invalidation & forward custom headers #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
716df0c
added ability to forward client's headers
Nov 16, 2016
01102aa
force making request from api
Nov 16, 2016
366cf0d
Merge branch 'master' into master
dvonlehman Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,12 @@ module.exports = function(options) {
originalQuery: false
});

options.headersToPreserveInCache =
_.map(_.union(options.headersToPreserveInCache, headersToPreserveInCache), (h) => h.toLowerCase());

return function(req, res, next) {
var method = req.method.toUpperCase();
var force = req.query.force || false;

// Allow for a global cache to be specified on the parent Express app
if (!options.cache) {
Expand All @@ -56,7 +60,7 @@ module.exports = function(options) {
}
}

if (method.toUpperCase() === 'GET' && options.cache && options.cacheMaxAge > 0) {
if (method.toUpperCase() === 'GET' && options.cache && options.cacheMaxAge > 0 && !force) {
if (!options.cache) return next(new Error('No cache provider configured'));

return proxyViaCache(req, res, next);
Expand Down Expand Up @@ -177,7 +181,7 @@ module.exports = function(options) {
}

// Store the headers as a separate cache entry
var headersToKeep = _.pick(resp.headers, headersToPreserveInCache);
var headersToKeep = _.pick(resp.headers, options.headersToPreserveInCache);

if (_.isArray(options.transforms)) {
apiRequest = applyTransforms(apiRequest, options.transforms, headersToKeep);
Expand Down