refactor(claudecode): centralize .claude/settings.json permissions ownership in a gateway#2115
Open
saitota wants to merge 1 commit into
Open
refactor(claudecode): centralize .claude/settings.json permissions ownership in a gateway#2115saitota wants to merge 1 commit into
saitota wants to merge 1 commit into
Conversation
…nership in a gateway The rule for who owns which entries inside .claude/settings.json permissions was duplicated across the ignore and permissions features: both knew the Read(...) deny entry format, and permissions guessed about the ignore feature by name in a warning string. Extract that shared contract into a single gateway so each feature only states its intent. No change to generated output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Who owns which entries inside
.claude/settings.jsonpermissionslived in two places:ignorewritesRead(...)intopermissions.deny,permissionswrites the wholeallow/ask/deny, and both re-implemented the entry format and the preserve/overwrite rule —permissionseven guessed about the ignore feature by name in a warning. The two could drift while each feature's own tests kept passing. Ordering is already guarded byGENERATION_STEP_GRAPH(#2081, #2109); this closes the remaining merge/ownership half.Changes
claudecode-settings-gateway.tsowns thepermissionsentry format, merge, and cross-feature ownership rule (permissions'Readrules win over ignore-derivedReaddenies).ignoreandpermissionsnow state intent only; the warning drops itspossibly from ignore featureguess.No change to generated output. Claude Code only, matching the staged-adoption note in #2081.
Test Plan
pnpm cicheckgreen (6749 tests).Refs #2081, #2109