test(e2e): assert the generate matrix covers every declared tool target#2116
Open
saitota wants to merge 1 commit into
Open
test(e2e): assert the generate matrix covers every declared tool target#2116saitota wants to merge 1 commit into
saitota wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution! Unfortunately, this PR has 1354 added lines, which exceeds the limit of 1000 lines for external contributors. Please split your changes into smaller PRs. See CONTRIBUTING.md for details. |
aedc93f to
e346d24
Compare
Contributor
Author
|
Trimmed comments: now +1,318 / -884. |
e346d24 to
8067396
Compare
8067396 to
469ba7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Which tools a feature supports, and where each writes output, lives in two places — the implementation (
getToolTargets()) and the hardcodedit.eacharrays insrc/e2e/*.spec.ts— with nothing connecting them. CLAUDE.md having to tell a human "preserve the Tool × Feature matrix tests" is the evidence it was never mechanized. So adding a tool (32 in H1 2026) means reconstructing from memory which specs need new rows; a miss leaves CI green while coverage silently drifts.Changes
assertGenerateMatrixCoversTargets(e2e-helper): derives the tool set fromgetToolTargets()and asserts declared targets partition exactly into the matrix's tested tools plus an explicit, reasoneduntestedlist — a declared-but-absent tool or a stray entry now fails CI.-legacyaliases are excluded, as the supported-tools tables already do.Same "derive from implementation, fail on drift" idiom as the TOOL_DISPLAY check and gitignore derivation. Per-tool expected paths stay hand-written; only the enumeration is derived.
Test Plan
pnpm cicheckgreen (6740 tests).