Skip to content

fix(sources): handle root skill with metadata dirs#2118

Merged
dyoshikawa merged 1 commit into
dyoshikawa:mainfrom
rudironsoni:fix/declarative-sources-miss-root-skill-md-metadata-dirs
Jul 6, 2026
Merged

fix(sources): handle root skill with metadata dirs#2118
dyoshikawa merged 1 commit into
dyoshikawa:mainfrom
rudironsoni:fix/declarative-sources-miss-root-skill-md-metadata-dirs

Conversation

@rudironsoni

Copy link
Copy Markdown
Contributor

Summary

Fixes #2117.

  • allow explicit single-skill declarative sources to install a root-level SKILL.md even when unrelated top-level metadata directories exist
  • keep wildcard behavior and real matching skill directories preferred over root fallback
  • add git and GitHub transport regression coverage for root SKILL.md plus .claude-plugin metadata
  • ignore TokenSave local state through the generated gitignore source registry

Root cause

Root fallback was gated on there being no discovered top-level skill directories. Repositories like blader/humanizer include root SKILL.md plus metadata directories such as .claude-plugin/, so discovery saw a directory, skipped fallback, then filtered out the metadata directory and fetched zero skills.

Validation

  • pnpm run check
  • pnpm run test
  • pnpm run check:supported-tools
  • pnpm run check:sync-skill-docs
  • pnpm run cspell
  • pnpm run secretlint
  • pnpm run dev gitignore
  • git diff --check

Copilot AI review requested due to automatic review settings July 3, 2026 16:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rudironsoni rudironsoni force-pushed the fix/declarative-sources-miss-root-skill-md-metadata-dirs branch from 4725455 to 6b2b425 Compare July 3, 2026 16:47
@dyoshikawa dyoshikawa merged commit d434d37 into dyoshikawa:main Jul 6, 2026
5 checks passed
@dyoshikawa

Copy link
Copy Markdown
Owner

@rudironsoni Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Declarative sources miss root SKILL.md when repo has metadata directories

3 participants