Container#672
Closed
Redmonkeycloud wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a Docker-based container workflow for running OPEN-PROM, including a dedicated container config and documentation to support single-scenario and batch executions.
Changes:
- Add a Docker image definition (R-based) with required system/R/Python dependencies and an entrypoint to
start.R. - Add a
docker-compose.yml, container-specific config (config.container.json), and environment template (.env.example) for mounting GAMS, inputs, and outputs. - Add Docker-specific documentation and ignore rules for build/run artifacts.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a “Docker setup” section pointing to the Docker documentation. |
| Dockerfile | Defines the container image, installs dependencies, and sets start.R as entrypoint. |
| docker/README.md | Provides Docker usage documentation (setup, runs, outputs, troubleshooting). |
| docker/install-r-packages.R | Installs required R packages (CRAN/R-universe/GitHub) during image build. |
| docker-compose.yml | Defines the open-prom service with mounts for data/targets/runs/outputs and GAMS. |
| config.container.json | Adds a container-targeted configuration (paths + default scenario/behavior). |
| .gitignore | Ignores outputs/ (and normalizes the scenarios.csv ignore line formatting). |
| .env.example | Adds a template for configuring GAMS_HOME for the GAMS mount. |
| .dockerignore | Excludes large/host-specific artifacts from the Docker build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+42
| ARG COMMON_DEFINITIONS_REPO="https://github.com/IAMconsortium/common-definitions.git" | ||
| ARG COMMON_DEFINITIONS_REF="main" | ||
| ENV IAMC_COMMON_DEFINITIONS=/opt/iamc/common-definitions | ||
|
|
||
| RUN python3 -m pip install --no-cache-dir --break-system-packages nomenclature-iamc \ | ||
| && mkdir -p /opt/iamc \ | ||
| && git clone --depth 1 --branch ${COMMON_DEFINITIONS_REF} ${COMMON_DEFINITIONS_REPO} ${IAMC_COMMON_DEFINITIONS} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.