Requirements could not be serialised as LDAP filter strings, which blocked bridging p2 to the OSGi Repository Service. - #1107
Merged
merks merged 1 commit intoJul 27, 2026
Conversation
Contributor
|
What does |
Contributor
Author
|
You are right. Adding toLDAPString overrides to |
subyssurendran666
force-pushed
the
LDAP_Filter_support_for_requirements_211
branch
from
July 24, 2026 07:34
7bbe6e0 to
6839d9a
Compare
subyssurendran666
changed the title
subyssurendran666
force-pushed
the
LDAP_Filter_support_for_requirements_211
branch
2 times, most recently
from
July 27, 2026 08:06
5b0a11f to
80b4f1c
Compare
Contributor
Author
|
@merks could you please re-review whenever this you have a moment? Thanks. |
merks
requested changes
Jul 27, 2026
subyssurendran666
force-pushed
the
LDAP_Filter_support_for_requirements_211
branch
from
July 27, 2026 13:17
80b4f1c to
25f0a3e
Compare
Requirements could not be serialised as LDAP filter strings, which blocked bridging p2 to the OSGi Repository Service. Fixes IMatchExpression.toLDAPString() to work for all predefined RequiredCapability version-range expressions. Fixes: eclipse-equinox#211
subyssurendran666
force-pushed
the
LDAP_Filter_support_for_requirements_211
branch
from
July 27, 2026 13:23
25f0a3e to
7cc0afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements could not be serialised as LDAP filter strings, which blocked bridging p2 to the OSGi Repository Service. The root cause was that RequiredCapability match expressions store bound values as Parameter placeholder nodes, which the existing Equals/Compare serialisers could not handle.
The fix adds toLDAPString overrides to MatchExpression, Exists, and LambdaExpression. MatchExpression substitutes each Parameter with a Literal before delegating to the existing serialisers; Exists and LambdaExpression simply drop their wrappers.
Fixes: #211