Fix: DownloadStatus should carry information about its URI - #1109
Merged
merks merged 2 commits intoJul 30, 2026
Conversation
Add a uri field to DownloadStatus with getUri() and setUri(URI) accessors and include it in toString(). In RepositoryTransport, the URI was already flowing as a parameter through every status-creation path but was never attached to the resulting object — this wires it in at every construction site in download() and via thin public wrappers around the internal forStatus0/forException0 helpers so no construction point is missed. The same wrapper pattern is applied to RepositoryStatus for consistency, keeping both public API classes behaviourally equivalent. Fix: eclipse-equinox#178
subyssurendran666
force-pushed
the
DownloadStatus_should_carry_information_about_URI_178
branch
from
July 29, 2026 09:11
9c3c4dd to
74e1c24
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
merks
approved these changes
Jul 29, 2026
Contributor
|
Given you seem to have asked for something like this, do you want to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadStatus already tracked file size, last-modified timestamp, and transfer rate, but had no field to identify which URL the status was recorded for, making it impossible for callers to correlate a status object back to the download that produced it. A uri field is added with
getUri()/setUri(URI)accessors and included intoString(), following the same mutable-setter pattern as the existing fields to avoid any constructor API break. InRepositoryTransport, the URI was already flowing through as a parameter at everyDownloadStatusconstruction site but was never attached to the resulting object; this fix wires it in across all exit paths — success, cancellation, authentication failure, and retry exhaustion — via thin public wrappers around internal helpers, with the same pattern applied symmetrically to RepositoryStatus. Nine unit tests are added inDownloadStatusTestcovering the new field, thetoString()null fallback, and all four factory methods across both classes.Fix: #178