Skip to content

refactor: replace reviewdog with direct cargo calls and PR comment#67

Open
alexmohr wants to merge 1 commit into
mainfrom
feature/improve-workflows
Open

refactor: replace reviewdog with direct cargo calls and PR comment#67
alexmohr wants to merge 1 commit into
mainfrom
feature/improve-workflows

Conversation

@alexmohr

Copy link
Copy Markdown
Contributor

Summary

  • Remove rust-lint-and-format-action reviewdog integration (giraffate/clippy-action, reviewdog setup, checkstyle XML helpers)
  • Remove shared-config/cargo-fmt.sh and cargo-clippy.sh; pre-commit hooks now call cargo directly (language: system)
  • Nightly clippy runs warn-only (continue-on-error); findings are posted as a PR comment with a disclaimer that they are informational and may be unrelated to PR changes; no comment posted when clean
  • New action inputs: toolchain, all-features, post-pr-comment
  • Document RUSTUP_TOOLCHAIN=nightly as the local opt-in for nightly clippy via prek

Checklist

  • I have tested my changes locally
  • I have added or updated documentation
  • I have linked related issues or discussions
  • I have added or updated tests

Related

Notes for Reviewers

@alexmohr alexmohr force-pushed the feature/improve-workflows branch 12 times, most recently from 3488859 to bc47422 Compare June 17, 2026 12:47
@alexmohr alexmohr marked this pull request as ready for review June 17, 2026 13:37
@alexmohr alexmohr force-pushed the feature/improve-workflows branch from bc47422 to 0ae1c3c Compare June 18, 2026 16:01
- Remove rust-lint-and-format-action reviewdog integration
  (giraffate/clippy-action, reviewdog setup, checkstyle XML helpers)
- Remove shared-config/cargo-fmt.sh and cargo-clippy.sh; pre-commit
  hooks now call cargo directly (language: system)
- Nightly clippy runs warn-only (continue-on-error); findings are
  posted as a PR comment with a disclaimer that they are informational
  and may be unrelated to PR changes; no comment posted when clean
- New action inputs: toolchain, all-features, post-pr-comment
- Document RUSTUP_TOOLCHAIN=nightly as the local opt-in for nightly
  clippy via prek

Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
@alexmohr alexmohr force-pushed the feature/improve-workflows branch from 0ae1c3c to 5afa22d Compare June 18, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant