Find/Replace overlay: separate command infrastructure into dedicated class#4184
Merged
HeikoKlare merged 1 commit intoJul 14, 2026
Conversation
HeikoKlare
force-pushed
the
findreplace-overlay-extract-overlaycommandsupport
branch
from
08623b5 to
c56ac83
Compare
Contributor
class Introduce FindReplaceOverlayCommandSupport to own the overlay's command-related infrastructure. As a first step, move the workaround that disables the target text editor's global action handlers (setTextEditorActionsActivated and DeactivateGlobalActionHandlers) out of FindReplaceOverlay into this new class. FindReplaceOverlay now only calls commandSupport.onFocusGained/Lost(). Contributes to eclipse-platform#1912 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
HeikoKlare
force-pushed
the
findreplace-overlay-extract-overlaycommandsupport
branch
from
c56ac83 to
766a139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Find/Replace overlay's command-related infrastructure — in particular the workaround that disables the target text editor's global action handlers while the overlay has focus — was embedded directly in
FindReplaceOverlay. This made the class responsible for both UI layout and command lifecycle management.This is part of the ongoing effort to separate concerns in the Find/Replace overlay, tracked in issue #1912.
Change
Introduce
FindReplaceOverlayCommandSupportto own the overlay's command-related infrastructure. As a first step, the workaround that disables the target text editor's global action handlers (setTextEditorActionsActivatedandDeactivateGlobalActionHandlers) is moved out ofFindReplaceOverlayinto this new class.FindReplaceOverlaynow only callscommandSupport.onFocusGained/Lost()when its text controls gain or lose focus.Towards proper Eclipse key binding handlers
Having a dedicated class own all command infrastructure is a prerequisite for incrementally replacing the current reflection-based workaround with proper Eclipse command-framework handlers for the overlay actions. This change prepares that future migration. It follows:
This change was created with the help of GitHub Copilot.