Baselibs AutoSD Fixes by odra · Pull Request #261 · eclipse-score/baselibs

odra · 2026-06-10T09:46:52Z

Changes

Fixes warnings for GCC 14 (used in AutoSD)
~~Explicit usage of -D_GNU_SOURCE for GCC 14 (does not break GCC 12)~~

github-actions · 2026-06-10T09:55:04Z

The created documentation from the pull request is available at: docu-html

4og · 2026-06-11T09:55:21Z

@fbaeuerle, can you please have a look?

Copilot

Pull request overview

This PR updates build/test code to address GCC 14 warnings in the AutoSD environment, including explicitly defining _GNU_SOURCE for the OpenSSL build configuration.

Changes:

Extend the OpenSSL Bazel transition to add -D_GNU_SOURCE via //command_line_option:copt.
Update multiple unit tests to avoid GCC 14 self-move and pessimizing-move warnings (e.g., self-move assignment patterns, unnecessary std::move on return values).
Refactor a few JSON parser tests to avoid reference binding patterns that trigger newer compiler diagnostics.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
third_party/openssl/openssl_transition.bzl	Adds `-D_GNU_SOURCE` to OpenSSL’s transitioned `--copt` settings.
score/memory/shared/lock_file_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/language/safecpp/scoped_function/scope_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/language/safecpp/scoped_function/details/allocator_wrapper_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/language/safecpp/scoped_function/details/allocator_aware_type_erasure_pointer_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/json/internal/parser/parsers_test_suite.h	Refactors value extraction in tests to avoid problematic reference patterns under newer compilers.
score/containers/intrusive_list_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/containers/dynamic_array_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/concurrency/task_result_test.cpp	Removes unnecessary `std::move` on return value to avoid pessimizing-move warnings.
score/concurrency/future/interruptible_shared_future_test.cpp	Removes unnecessary `std::move` on temporaries to avoid pessimizing-move warnings.
score/concurrency/future/base_interruptible_promise_test.cpp	Adjusts self-move assignment test to avoid compiler self-move diagnostics.
score/concurrency/future/base_interruptible_future_test.cpp	Removes unnecessary `std::move` on temporaries to avoid pessimizing-move warnings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    current = list(settings["//command_line_option:features"])
+    current_copts = settings.get("//command_line_option:copt", [])
    updated = []


4og · 2026-06-16T15:16:32Z


 def _openssl_transition_impl(settings, attr):
    current = list(settings["//command_line_option:features"])
+    current_copts = settings.get("//command_line_option:copt", [])


It's now possible to inject an own openssl lib via a label_flag:

baselibs/third_party/openssl/BUILD

Lines 17 to 25 in 41b4af6

# Allows integrating workspaces to redirect the OpenSSL crypto implementation

# without modifying this file. The default points to the BCR-provided module.

# Override example (in the integrating workspace's .bazelrc):

# build --@score_baselibs//third_party/openssl:openssl_crypto_impl=//my/openssl:target

label_flag(

name = "openssl_crypto_impl",

build_setting_default = "@openssl//:crypto",

visibility = ["//visibility:public"],

)

Would this be a better option than changing compile options in this transition?

Is the idea here to provide an alternative Bazel module / component to manage the openssl build / integration in baselibs?

Correct, it gives an option to substitute openssl from BCR with the openssl provided by the system.

ok, that makes sense. let me remove my openssl change from this pr then.

paulquiring · 2026-06-17T12:28:19Z

Looks like redundant-move was issued as warning, to remove the redundant moves is legitimate.

paulquiring · 2026-06-17T12:39:17Z


-    // when doing a self-move-assign
-    unit = std::move(unit);
+    // when doing a self-move-assign (use pointer indirection to avoid compiler warning)


The self move warnings can be suppressed like this

DISABLE_WARNING_PUSH DISABLE_WARNING_SELF_MOVE scope = std::move(scope);

see

paulquiring · 2026-06-17T13:37:53Z

    auto root = TypeParam::FromBuffer(buffer_simple_json);

    // When reading a key of an object that is interpreted as number
-    auto& value = GetValueOfObject<Object>(root.value(), "object");


I wonder if just removing the & would also work to get rid of the dangling-reference error. Above it seems to work.

It fixed it for primitive types but it required a little bit for objects and lists.

GCC 14's -Werror=self-move detects self-move assignments. These occur in tests that intentionally verify self-move safety of various types. Solution: use pointer indirection to hide self-moves from compiler analysis: auto* ptr = &obj; obj = std::move(*ptr); This preserves the runtime behavior (self-move) while preventing the compile-time warning. Applied to test files for: DynamicArray, intrusive_list, Promise, AllocatorWrapper, TypeErasurePointer, Scope, and LockFile. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

GCC 14's -Werror=pessimizing-move detects std::move() on return values, which prevents copy elision and forces unnecessary move operations. Solution: remove std::move() from temporary return values and let the compiler apply copy elision optimization. Applied to 7 instances across: - base_interruptible_future_test.cpp (4 instances) - interruptible_shared_future_test.cpp (2 instances) - task_result_test.cpp (1 instance) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

4og · 2026-06-19T13:21:33Z

+    auto* target_ptr = &target;
+    target = std::move(*target_ptr);


How does the compiler warning look like?
With the DISABLE_WARNING_PUSH above there shouldn't be the need to change this code.

odra requested review from 4og and antonkri as code owners June 10, 2026 09:46

github-project-automation Bot added this to BAS - Baselibs FT Jun 10, 2026

github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Jun 10, 2026

odra temporarily deployed to workflow-approval June 10, 2026 09:46 — with GitHub Actions Inactive

odra changed the title ~~gBaselibs autosd fix~~ Baselibs AutoSD Fixes Jun 10, 2026

4og assigned fbaeuerle Jun 11, 2026

4og requested review from Copilot and fbaeuerle June 11, 2026 09:55

Copilot started reviewing on behalf of 4og June 12, 2026 20:42 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Comment thread third_party/openssl/openssl_transition.bzl

Comment on lines 41 to 43

current = list(settings["//command_line_option:features"])

current_copts = settings.get("//command_line_option:copt", [])

updated = []

4og reviewed Jun 16, 2026

View reviewed changes

odra force-pushed the baselibs-autosd-fix branch from 7e395b9 to b9ffc55 Compare June 17, 2026 11:01

odra temporarily deployed to workflow-approval June 17, 2026 11:02 — with GitHub Actions Inactive

paulquiring reviewed Jun 17, 2026

View reviewed changes

paulquiring suggested changes Jun 17, 2026

View reviewed changes

pypingou and others added 3 commits June 18, 2026 05:30

fix json parser tests dangling-reference for gcc14

1cdb9fc

Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

odra force-pushed the baselibs-autosd-fix branch from b9ffc55 to 1cdb9fc Compare June 18, 2026 09:30

odra temporarily deployed to workflow-approval June 18, 2026 09:31 — with GitHub Actions Inactive

4og reviewed Jun 19, 2026

View reviewed changes

4og requested a review from sankurm June 19, 2026 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Baselibs AutoSD Fixes#261

Baselibs AutoSD Fixes#261
odra wants to merge 3 commits into
eclipse-score:mainfrom
eclipse-score-fork-rh:baselibs-autosd-fix

odra commented Jun 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

4og commented Jun 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

4og Jun 16, 2026

Uh oh!

odra Jun 17, 2026

Uh oh!

4og Jun 17, 2026

Uh oh!

odra Jun 17, 2026

Uh oh!

paulquiring Jun 17, 2026

Uh oh!

paulquiring Jun 17, 2026

Uh oh!

paulquiring Jun 17, 2026

Uh oh!

odra Jun 18, 2026

Uh oh!

4og Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	# Allows integrating workspaces to redirect the OpenSSL crypto implementation
	# without modifying this file. The default points to the BCR-provided module.
	# Override example (in the integrating workspace's .bazelrc):
	# build --@score_baselibs//third_party/openssl:openssl_crypto_impl=//my/openssl:target
	label_flag(
	name = "openssl_crypto_impl",
	build_setting_default = "@openssl//:crypto",
	visibility = ["//visibility:public"],
	)

Conversation

odra commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

4og commented Jun 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

odra commented Jun 10, 2026 •

edited

Loading