feat: add strict/permissive compiler warning profiles by AAmbuj · Pull Request #527 · eclipse-score/communication

AAmbuj · 2026-06-11T11:46:59Z

Introduce configurable warning features for GCC and Clang toolchains with two build modes controlled via --config=strict and --config=permissive.

Add quality/compiler_warnings/{BUILD,clang/BUILD,gcc/BUILD} with cc_feature definitions for minimal, strict, and additional warnings
Configure LLVM toolchain with extra_known_features (toolchains_llvm 1.7.0)
Configure GCC toolchain with extra_cxxflags baseline matching minimal_warnings
Add selective -Wno-error overrides in .bazelrc for permissive mode
Refactor score/message_passing BUILD files to use COMPILER_WARNING_FEATURES
Add FP/TP test targets with build_test verification
Document usage in quality/quality.md

MISRA C++:2023 Dir 1.1, Rules 6.4.1, 7.0.5, 8.2.3, 0.1.1 CWE-134, CWE-195, CWE-398, CWE-561, CWE-681

LittleHuba · 2026-06-12T10:23:22Z

You should also add the features to the S-CORE gcc toolchain

AAmbuj · 2026-06-13T10:14:24Z

This much warring turn into error when we implement the warring as a error feature in current code base: #539

LittleHuba · 2026-06-16T14:04:31Z

+        "//quality/compiler_warnings/clang:strict_warnings",
+        "//quality/compiler_warnings/clang:third_party_warnings",
+    ],
+    extra_link_libs = {"": [


These link flags should probably also go into a cc_feature that you reference in the extra_enabled_features here.

LittleHuba · 2026-06-16T14:31:44Z

+        # Clang Thread Safety Analysis. Detects potential data races through
+        # annotations (GUARDED_BY, REQUIRES, etc.). Essential for concurrent code.
+        # Ref: CERT C++ CON43-CPP — do not allow data races.
+        # Clang-specific: not available in GCC.
+        # Ref: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
+        "-Wthread-safety",


We currently do not use these annotations in our code.

Suggested change

# Clang Thread Safety Analysis. Detects potential data races through

# annotations (GUARDED_BY, REQUIRES, etc.). Essential for concurrent code.

# Ref: CERT C++ CON43-CPP — do not allow data races.

# Clang-specific: not available in GCC.

# Ref: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html

"-Wthread-safety",

LittleHuba · 2026-06-16T14:36:48Z

+        # -Wshadow-all sub-categories are NOT subcategories of -Wshadow for
+        # -Wno-error purposes. Downgrade these individually so that the global
+        # -Werror does not reject them during migration.
+        "-Wno-error=shadow-uncaptured-local",
+        "-Wno-error=shadow-field",


Discussed with @limdor. We decided to enable -Wshadow-all.

Suggested change

# -Wshadow-all sub-categories are NOT subcategories of -Wshadow for

# -Wno-error purposes. Downgrade these individually so that the global

# -Werror does not reject them during migration.

"-Wno-error=shadow-uncaptured-local",

"-Wno-error=shadow-field",

LittleHuba · 2026-06-16T15:26:27Z

+    (void)context;
+    (void)reserved;


Better use the C++ way of doing this, since we also suggest that in proper production code.

Suggested change

(void)context;

(void)reserved;

std::ignore = context;

std::ignore = reserved;

LittleHuba · 2026-06-16T15:28:11Z

You must split this to one bazel target per flag you test. Otherwise you only test the first flag that causes an error.

LittleHuba · 2026-06-16T15:28:40Z

+{
+    virtual void process(std::int32_t x)
+    {
+        (void)x;


LittleHuba · 2026-06-16T15:28:45Z

+{
+    void process(double x)
+    {
+        (void)x;


LittleHuba · 2026-06-16T15:30:28Z

+9 functions, each triggering exactly one warning category:
+
+| Function | Warning flag | Feature | MISRA / CWE |
+|----------|-------------|---------|-------------|
+| `implicit_narrowing` | `-Wfloat-conversion` | `score_communication_strict_warnings` | MISRA Rule 7.0.5, CWE-681 |
+| `variable_shadowing` | `-Wshadow` | `score_communication_strict_warnings` | MISRA Rule 6.4.1, CWE-398 |
+| `signed_unsigned_compare` | `-Wsign-compare` | `score_communication_strict_warnings` | CWE-195, CWE-697 |
+| `unused_parameter` | `-Wunused-parameter` | `score_communication_strict_warnings` | MISRA Rule 0.1.1, CWE-561 |
+| `delete_polymorphic` | `-Wdelete-non-virtual-dtor` | `score_communication_strict_warnings` (C++) | MISRA Rule 15.7.1 |
+| `VDerived::process` | `-Woverloaded-virtual` | `score_communication_strict_warnings` (C++) | MISRA Rule 10.2.0 |
+| `cast_away_const` | `-Wcast-qual` | `score_communication_additional_warnings` | MISRA Rule 8.2.3 |
+| `format_nonliteral` | `-Wformat-nonliteral` | `score_communication_additional_warnings` | CWE-134 |
+| `#if UNDEFINED_MACRO` | `-Wundef` | `score_communication_additional_warnings` | MISRA Dir 4.4 |


Ideally we have one function per flag. That way we can make sure that actually every flag triggers as expected.

LittleHuba · 2026-06-16T15:31:03Z

+# Sanitizer configs activate LLVM automatically
+bazel test --config=asan_ubsan_lsan //quality/compiler_warnings/test:fp_build_test
+bazel test --config=tsan            //quality/compiler_warnings/test:fp_build_test


Misleading in this docu.

Suggested change

# Sanitizer configs activate LLVM automatically

bazel test --config=asan_ubsan_lsan //quality/compiler_warnings/test:fp_build_test

bazel test --config=tsan //quality/compiler_warnings/test:fp_build_test

LittleHuba · 2026-06-17T14:43:37Z

+# Self-contained copies of the warning features under test. The real features
+# live in //quality/compiler_warnings/{clang,gcc}:BUILD; they are duplicated
+# here (Clang flag set) because a nested workspace cannot reference the parent
+# module's targets.


Hmm this restriction is awful. Let me think about a better way.

Done using suggested method https://github.com/yuyawk/rules_build_error

LittleHuba · 2026-06-17T14:47:23Z

+    # Temporarily disabled for sanitizer test runs (ASAN/TSAN).
+    # Re-enable after shadow/deprecation warnings are fixed in dependencies.
+    # "score_communication_treat_warnings_as_errors",
+    # "score_communication_strict_warnings",


Better would be to introduce a score_communication_strict_warnings_no_error and degrade the flags that cause errors to warnings. That way we can enable this and slowly work towards improving the situation.

after score_communication_strict_warnings_no_error enable this much changes only required to merge our PR. #558

LittleHuba · 2026-06-17T14:48:17Z

+    extra_compile_flags = SCORE_GCC_MINIMAL_WARNING_COMPILE_FLAGS,
+    extra_cxx_compile_flags = SCORE_GCC_MINIMAL_WARNING_CXX_FLAGS,


Is there no support for cc_features?

Currently not on this path. cc_features are wired for LLVM, but GCC/QCC still require compile flag injection, so these two lines are a temporary compatibility step until upstream feature support is available.

Introduce configurable warning features for GCC and Clang toolchains with two build modes controlled via --config=strict and --config=permissive. - Add quality/compiler_warnings/{BUILD,clang/BUILD,gcc/BUILD} with cc_feature definitions for minimal, strict, and additional warnings - Configure LLVM toolchain with extra_known_features (toolchains_llvm 1.7.0) - Configure GCC toolchain with extra_cxxflags baseline matching minimal_warnings - Add selective -Wno-error overrides in .bazelrc for permissive mode - Refactor score/message_passing BUILD files to use COMPILER_WARNING_FEATURES - Add FP/TP test targets with build_test verification - Document usage in quality/quality.md MISRA C++:2023 Dir 1.1, Rules 6.4.1, 7.0.5, 8.2.3, 0.1.1 CWE-134, CWE-195, CWE-398, CWE-561, CWE-681

AAmbuj force-pushed the amsh_feat_compiler_warning_features branch 5 times, most recently from e879777 to e05eb47 Compare June 12, 2026 06:41

LittleHuba reviewed Jun 12, 2026

View reviewed changes

AAmbuj force-pushed the amsh_feat_compiler_warning_features branch from e05eb47 to ce81645 Compare June 13, 2026 10:09

AAmbuj force-pushed the amsh_feat_compiler_warning_features branch 2 times, most recently from 93129c1 to cb0811e Compare June 15, 2026 09:20

AAmbuj self-assigned this Jun 16, 2026

LittleHuba reviewed Jun 16, 2026

View reviewed changes

Comment thread score/mw/common_features.bzl

LittleHuba reviewed Jun 16, 2026

View reviewed changes

Comment thread quality/compiler_warnings/clang/BUILD

LittleHuba reviewed Jun 16, 2026

View reviewed changes

Comment thread quality/compiler_warnings/clang/BUILD

LittleHuba reviewed Jun 16, 2026

View reviewed changes

AAmbuj force-pushed the amsh_feat_compiler_warning_features branch 4 times, most recently from 6b98546 to 9ffba9d Compare June 17, 2026 12:44

LittleHuba reviewed Jun 17, 2026

View reviewed changes

AAmbuj force-pushed the amsh_feat_compiler_warning_features branch 2 times, most recently from 6576505 to ff9eef0 Compare June 18, 2026 05:44

AAmbuj force-pushed the amsh_feat_compiler_warning_features branch from ff9eef0 to af7062c Compare June 18, 2026 06:35

	# Sanitizer configs activate LLVM automatically
	bazel test --config=asan_ubsan_lsan //quality/compiler_warnings/test:fp_build_test
	bazel test --config=tsan //quality/compiler_warnings/test:fp_build_test

		extra_compile_flags = SCORE_GCC_MINIMAL_WARNING_COMPILE_FLAGS,
		extra_cxx_compile_flags = SCORE_GCC_MINIMAL_WARNING_CXX_FLAGS,

Conversation

AAmbuj commented Jun 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AAmbuj commented Jun 13, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LittleHuba Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LittleHuba Jun 17, 2026 •

edited

Loading