Skip to content

fix(codeql): correct target pattern and fail loudly on analysis errors#531

Merged
castler merged 1 commit into
eclipse-score:mainfrom
Komal362000:koma_codeqltest
Jun 12, 2026
Merged

fix(codeql): correct target pattern and fail loudly on analysis errors#531
castler merged 1 commit into
eclipse-score:mainfrom
Komal362000:koma_codeqltest

Conversation

@Komal362000

Copy link
Copy Markdown
Contributor

Fixes two issues found in the nightly CodeQL workflow:

  1. Corrected --target from //score/message_passing/... //score/mw/com/...
    to //score/message_passing //score/mw/com (removes recursive wildcard).

  2. Replaced silent os.system() calls in analyze_database with
    subprocess.run(..., check=True) so analysis failures are caught
    immediately instead of silently producing missing output files.

Without this fix, the nightly job fails at the SARIF upload step with
"Path does not exist" because the analysis silently errored out earlier.
failed pr (#521)

@castler castler marked this pull request as ready for review June 12, 2026 06:11
@castler castler added this pull request to the merge queue Jun 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 12, 2026
@castler castler merged commit c619c56 into eclipse-score:main Jun 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants