Feat/codeql results dashboard#561
Draft
Komal362000 wants to merge 29 commits into
Draft
Conversation
…v2.60.0 fix(codeql): update misra-cpp-coding-standards pack to v2.60.0
Feat/codeql results dashboard
- Dashboard heading: 'CodeQL (MISRA C++)' → 'CodeQL' - codeql.yml: override ape+ repository with empty stub to bypass GitLab ARM 403 in GitHub Actions (ARM toolchain not needed for CodeQL analysis)
fix(quality): rename CodeQL title and stub ape dep for CI
- Add codeql_report.html.j2 template for standalone findings page - Update generate_dashboard.py with --codeql-html flag and renderer - Update nightly_quality.yml to generate quality/codeql/index.html - Update generate_quality_links.bzl to link to HTML report instead of CSV - Dashboard title changed to 'CodeQL' (not 'CodeQL (MISRA C++)')
feat(quality): add CodeQL HTML report page (like coverage)
fix(quality): add ape stub to deploy job in nightly_quality.yml
fix(quality): add codeql_report.html.j2 to BUILD data deps
- Modified load_codeql_csv() to return 'loaded: True' flag - Updated render_codeql_report() to pass 'loaded' flag to template - Changed codeql_report.html.j2: Check 'loaded' flag instead of findings list * Shows summary cards (0,0,0,0) when CodeQL runs with 0 issues ✓ * Shows findings table when CodeQL finds issues ✓ * Shows 'No data' message only when CSV is missing ✓
Signed-off-by: Komal362000 <109155302+Komal362000@users.noreply.github.com>
- Enhanced load_codeql_csv() to handle multiple column name variations - Added debug logging: column names, severity distribution - Added diagnose_codeql_csv.py tool to identify CSV format issues - Supports more severity values: error, fail, warning, warn, recommendation - Handles edge cases: empty severity, missing columns, different case This helps identify root cause of 6411 recommendations issue: - When severity field is empty, findings are treated as recommendations - New diagnostic tool can identify actual CodeQL CSV format from CI
BREAKING CHANGES: - Removed CodeQL HTML report generation (codeql_report.html.j2, render_codeql_report) - CodeQL CSV now served directly like clang-tidy findings (raw .csv file) - Updated quality_reports.rst to link to CSV file instead of HTML report - Removed diagnostic tool (diagnose_codeql_csv.py) SIMPLIFICATIONS: - Dashboard shows only: Coverage, Clang-Tidy, CodeQL cards (no per-file coverage) - Merged CodeQL Recommendations into Errors category - Removed --codeql-html argument from workflows - CodeQL data now consolidated in main dashboard only BENEFITS: - Simpler implementation (CSV shows raw data) - Matches coverage/clang-tidy pattern (direct file serving) - Reduces code complexity by ~200 lines - Clearer data presentation
CHANGE: - Rename codeql_findings.csv → codeql_findings.txt - GitHub Pages now serves as text/plain (displays in browser) - Matches clang-tidy.txt pattern (no download prompt) WHY THIS WORKS: - .csv files trigger 'Content-Type: text/csv' → download - .txt files trigger 'Content-Type: text/plain' → display in browser - Content stays identical (CSV format in .txt file) RESULT: ✅ Click CodeQL link → Shows findings in browser ✅ No download prompt ✅ Same experience as clang-tidy findings
- Removed cvSort() function that referenced deleted cv-tbody element - Template now renders without errors - Dashboard should deploy successfully
The escaped quotes ("${...}") in the workflow were breaking the command.
Changed to regular quotes without backslashes so the paths are correctly expanded.
This was preventing the dashboard from being generated, causing 404 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.