Cryptoki etas integration#49
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
This document containt a directive workproduct, please remove, does not exits, is only used in process description,
| @@ -91,6 +91,7 @@ The components are designed to cover the expectations from the feature architect | |||
| :safety: QM | |||
| :status: invalid | |||
| :implements: | |||
There was a problem hiding this comment.
why invalid and not draft?
| @@ -22,7 +22,8 @@ API Dynamic Architecture | |||
| :security: YES | |||
| :safety: QM | |||
| :status: invalid | |||
| :status: invalid | ||
| :fulfils: | ||
| :belongs_to: comp__crypto | ||
| :fulfils: wp__cmpt_request_dummy |
There was a problem hiding this comment.
not correct, fulfils should link to requirements somewhere. e.g. compare https://eclipse-score.github.io/process_description/main/general_concepts/score_traceability_concept.html
|
80k lines. Sorry, but I'm not able to review that. Is it possible to create smaller, readable PR's? |
|
Kindly check the PR again and resolve the merge conflicts. |
# Conflicts: # .gitignore # BUILD # CONTRIBUTION.md # MODULE.bazel # NOTICE # docs/conf.py # docs/index.rst # examples/BUILD # project_config.bzl # src/BUILD # tests/config/BUILD # tests/config/run_rust_tests.sh # tests/cpp/test_main.cpp # tests/rust/test_main.rs # tests/test_vectors/key_management/BUILD # tests/test_vectors/key_management/run_cpp_tests.sh # tests/test_vectors/key_management/run_pkcs11test.sh # tests/test_vectors/key_management/run_test_cpp.sh
Co-authored-by: Copilot <copilot@github.com>
# Conflicts: # .bazelrc # .gitignore # BUILD # MODULE.bazel.lock # docs/crypto/architecture/dynamic_architecture.rst # docs/crypto/architecture/index.rst # examples/BUILD # score/crypto/daemon/provider/pkcs11/BUILD # score/crypto/daemon/provider/pkcs11/detail/pkcs11_algorithm_info.hpp # score/crypto/daemon/provider/pkcs11/key_management/pkcs11_key_store.hpp # score/crypto/daemon/provider/pkcs11/operations/hash/pkcs11_hash_context.hpp # score/crypto/daemon/provider/pkcs11/operations/hash/pkcs11_hash_handler.hpp # score/crypto/daemon/provider/pkcs11/operations/key_management/pkcs11_key_management_handler.hpp # score/crypto/daemon/provider/pkcs11/operations/mac/pkcs11_mac_context.hpp # score/crypto/daemon/provider/pkcs11/operations/mac/pkcs11_mac_executor.hpp # score/crypto/daemon/provider/pkcs11/operations/mac/pkcs11_mac_handler.hpp # score/crypto/daemon/provider/pkcs11/pkcs11_module.hpp # score/crypto/daemon/provider/pkcs11/pkcs11_provider.cpp # score/crypto/daemon/provider/pkcs11/pkcs11_provider.hpp # score/crypto/daemon/provider/pkcs11/pkcs11_provider_factory.cpp # score/crypto/daemon/provider/pkcs11/pkcs11_token_config.cpp # score/crypto/daemon/src/daemon.cpp # tests/config/run_rust_tests.sh # tests/integration_tests/BUILD # tests/integration_tests/init_softhsm_token.cpp # tests/test_vectors/key_management/run_cpp_tests.sh # tests/test_vectors/key_management/run_test_cpp.sh # third_party/openssl/BUILD
08329fb to
94701aa
Compare
3724b28 to
4d92606
Compare
Fix the static library link order for OpenSSL (libssl before libcrypto) to resolve undefined symbols during linking. Additionally, apply missing Eclipse Foundation copyright headers to newly added Cryptoki source files to pass the copyright checker.
4d92606 to
cc51b96
Compare
|
test_pkcs11_provider fails when compiled with USE_RUST_PKCS11 ("C_InitToken failed: 160"). ./bazel-bin/tests/provider_test/test_pkcs11_provider [----------] Global test environment tear-down |
Key Changes:
Integrated the cryptoki module natively into the score_crypto.
Moved the cryptoki provider to score/crypto/daemon/provider/pkcs11/cryptoki.
Updated all Bazel build configurations, Cargo dependencies, and lockfiles to correctly map to the new path.
Verified that the daemon, integration tests, and multi-provider demos build and pass successfully with the new provider location.
Use a single source for openssl (ETAS provided version) found under third_party/openssl
Integrate SCORE Logger into Cryptoki code
closes Integrate PKCS11 (Cryptoki) to SCORE #29 (children tasks PKCS11 (Cryptoki) Integration with SCORE #31 and Integration of PKCS11 (Cryptoki) With ETAS Architecture #32)
closes Have only one version of OpenSSL on target #30 (child task Selecting One OpenSSL Version for the Security Code #33)
Your Reviews will be appreciated @ChansAlive @PandaeDo @masc2023 @schreibwsag @OliverHeilwagen