Skip to content

Fix time_slave component to meet S-CORE conventions#52

Merged
NEOatNHNG merged 4 commits into
eclipse-score:mainfrom
gordon9901:ecarx_pr1_rename
Jun 12, 2026
Merged

Fix time_slave component to meet S-CORE conventions#52
NEOatNHNG merged 4 commits into
eclipse-score:mainfrom
gordon9901:ecarx_pr1_rename

Conversation

@gordon9901

@gordon9901 gordon9901 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Make it meet naming and folder conventions (fixes #20)

@github-project-automation github-project-automation Bot moved this to In Progress in TIM - Time FT Jun 2, 2026
@gordon9901 gordon9901 requested a deployment to workflow-approval June 2, 2026 07:25 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 2, 2026 07:25 — with GitHub Actions Waiting
@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5e7e220b-4584-4b7d-91bb-7360e946fd54
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.5.3, but got aspect_rules_lint@2.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (77 packages loaded, 9 targets configured)

Analyzing: target //:license-check (148 packages loaded, 2654 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6314 targets configured)

Analyzing: target //:license-check (169 packages loaded, 8047 targets configured)

Analyzing: target //:license-check (169 packages loaded, 8049 targets configured)

Analyzing: target //:license-check (169 packages loaded, 8049 targets configured)

Analyzing: target //:license-check (169 packages loaded, 8049 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9937 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9937 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9937 targets configured)

Analyzing: target //:license-check (173 packages loaded, 10058 targets configured)

Analyzing: target //:license-check (173 packages loaded, 10058 targets configured)

Analyzing: target //:license-check (173 packages loaded, 10058 targets configured)

INFO: Analyzed target //:license-check (174 packages loaded, 10184 targets configured).
[11 / 16] [Prepa] Expanding template external/score_tooling+/dash/tool/formatters/_dash_format_converter_stage2_bootstrap.py [for tool]
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 43.409s, Critical Path: 2.49s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@gordon9901 gordon9901 requested a deployment to workflow-approval June 2, 2026 08:59 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 2, 2026 08:59 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 2, 2026 10:12 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 2, 2026 10:12 — with GitHub Actions Waiting
BjoernAtBosch
BjoernAtBosch suggested changes Jun 3, 2026
View reviewed changes

@BjoernAtBosch BjoernAtBosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gao,
some smaller findings ...

Comment thread score/time_slave/docs/component_classification.rst Outdated
Comment thread score/time_slave/docs/index.rst Outdated
Comment thread score/time_slave/src/gptp/details/i_network_identity.h Outdated
Comment thread score/time_slave/src/gptp/details/raw_socket.h
Comment thread score/time_slave/src/gptp/gptp_engine.cpp Outdated
Comment thread docs/features/time_slave/index.rst Outdated
Comment thread docs/features/requirements.rst Outdated
@gordon9901 gordon9901 requested a deployment to workflow-approval June 3, 2026 10:18 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 3, 2026 10:18 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a review from BjoernAtBosch June 3, 2026 10:25
BjoernAtBosch
BjoernAtBosch reviewed Jun 3, 2026
View reviewed changes
Comment thread score/time_slave/src/gptp/details/os_syscalls.h
BjoernAtBosch
BjoernAtBosch suggested changes Jun 3, 2026
View reviewed changes

@BjoernAtBosch BjoernAtBosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i_os_syscalls.h also needs to be renamed

@gordon9901 gordon9901 requested a deployment to workflow-approval June 4, 2026 02:10 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 4, 2026 02:10 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a review from BjoernAtBosch June 4, 2026 02:20
BjoernAtBosch
BjoernAtBosch approved these changes Jun 4, 2026
View reviewed changes

@BjoernAtBosch BjoernAtBosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lavrovvalera
lavrovvalera suggested changes Jun 5, 2026
View reviewed changes
Comment thread docs/features/time_daemon/_assets/app/app_class.puml Outdated
Comment thread docs/features/time_daemon/index.rst Outdated
@gordon9901 gordon9901 requested a deployment to workflow-approval June 8, 2026 02:55 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a deployment to workflow-approval June 8, 2026 02:55 — with GitHub Actions Waiting
@gordon9901 gordon9901 requested a review from lavrovvalera June 8, 2026 03:04
BjoernAtBosch
BjoernAtBosch approved these changes Jun 8, 2026
View reviewed changes

@BjoernAtBosch BjoernAtBosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BlueXMarv3l BlueXMarv3l self-assigned this Jun 12, 2026
@BlueXMarv3l BlueXMarv3l moved this from In Progress to Done in TIM - Time FT Jun 12, 2026
NEOatNHNG
NEOatNHNG approved these changes Jun 12, 2026
View reviewed changes

@NEOatNHNG NEOatNHNG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content already reviewed by team.

@NEOatNHNG NEOatNHNG merged commit c40bf6d into eclipse-score:main Jun 12, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NEOatNHNG NEOatNHNG NEOatNHNG approved these changes

+2 more reviewers

@lavrovvalera lavrovvalera lavrovvalera approved these changes

@BjoernAtBosch BjoernAtBosch BjoernAtBosch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BlueXMarv3l BlueXMarv3l

Labels

None yet

Projects

TIM - Time FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement: Update the TimeSlave to comply to SCORE conventions

6 participants

@gordon9901 @NEOatNHNG @lavrovvalera @BjoernAtBosch @BlueXMarv3l @mwx2015