Add public rust_binary targets for rust_kvs examples#301
Draft
Subramanian-K812 wants to merge 1 commit into
Draft
Add public rust_binary targets for rust_kvs examples#301Subramanian-K812 wants to merge 1 commit into
Subramanian-K812 wants to merge 1 commit into
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four
rust_binarytargets tosrc/rust/rust_kvs/BUILD— one for eachexisting example source file in
src/rust/rust_kvs/examples/.Why
The
rust_kvscrate already ships example source files (basic.rs,custom_types.rs,defaults.rs,snapshots.rs) but they had no Bazel buildtargets. Without targets, external packages cannot reference these examples for
bundling or showcase use, forcing them to maintain their own copies of the demo
code.