Enable cr_checker copyright check via pre-commit hook#265
Draft
Subramanian-K812 wants to merge 4 commits into
Draft
Enable cr_checker copyright check via pre-commit hook#265Subramanian-K812 wants to merge 4 commits into
Subramanian-K812 wants to merge 4 commits into
Conversation
Subramanian-K812
force-pushed
the
Subramanian-K166_enable_cr_checker_precommit
branch
from
0ca2285 to
25e11de
Compare
PiotrKorkus
reviewed
Jun 17, 2026
| # @score_process/@score_platform; those are dev_dependencies in the score modules | ||
| # and so are not visible when reference_integration aggregates them. | ||
| # Tracked in https://github.com/eclipse-score/reference_integration/issues/166. | ||
| copyright_checker( |
Contributor
There was a problem hiding this comment.
remove then if not needed anymore
Subramanian-K812
force-pushed
the
Subramanian-K166_enable_cr_checker_precommit
branch
from
7aec564 to
6fa5c19
Compare
Member
|
LGTM; copyright checking is an unsolved problem. However the pre-commit version is better than the bazel version as can be observed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166
Summary
copyrightpre-commit hook fromeclipse-score/tooling, bypassing the broken Bazel//:copyrighttarget.Changes
Enabler
.pre-commit-config.yamlcopyrighthook fromeclipse-score/toolingrev31ff8eee.github/workflows/copyright.ymlpre-commit run copyright --all-fileson every PR and merge groupVerification