split sanitizers into per-sanitizer features, flags, and constraints#5
Merged
Merged
Conversation
RSingh1511
force-pushed
the
rs/sanitizer-split
branch
from
1a93c35 to
953168c
Compare
RSingh1511
force-pushed
the
rs/sanitizer-split
branch
from
953168c to
1c69b11
Compare
RSingh1511
force-pushed
the
rs/sanitizer-split
branch
from
83df2c4 to
07e724b
Compare
FScholPer
previously approved these changes
Jun 10, 2026
RSingh1511
force-pushed
the
rs/sanitizer-split
branch
from
07e724b to
1d1bd86
Compare
…eprecated shim - sanitizers/flags/BUILD.bazel: add _invalid_asan_tsan / _invalid_lsan_tsan config_setting_groups and a sanitizer_combination_check genrule that fails at build time for invalid combos; add deprecated :sanitizer string_flag shim with actionable error message pointing to migration guide - sanitizers/wrapper.sh: load env files in deterministic sorted order via find+sort instead of glob expansion; first-definition-wins semantics prevent silent variable clobber when multiple sanitizers are active simultaneously - tests/.bazelrc: add tsan_ubsan --extra_toolchains entry alongside asan_ubsan_lsan - tests/BUILD.bazel: add validate_sanitizer_combination genrule so that 'bazel test //...' enforces combination guards automatically - .github/workflows/tests.yml: add tsan_ubsan to sanitizer CI matrix - sanitizers/README.md: add valid combinations table and no_asan_ubsan_lsan before/after behaviour note
RSingh1511
force-pushed
the
rs/sanitizer-split
branch
from
1d1bd86 to
9d3550a
Compare
FScholPer
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split sanitizers into independent, composable units — each sanitizer (ASan, UBSan, LSan, TSan) now has its own bool_flag, Bazel feature, and execution constraint
Enables enabling any single sanitizer in isolation (--config=asan, --config=tsan, etc.)
Supports selective composition (--config=asan_ubsan_lsan)
Adds fine-grained constraints (no_asan, only_tsan, etc.) to skip tests incompatible with a specific sanitizer
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #4