Table: add support for dragging table rows by mouse#421
Open
bschwarzent wants to merge 1 commit into
Open
Conversation
cguglielmo
force-pushed
the
features/bsh/26.2/dnd-table
branch
from
2e11f8c to
4b2ef12
Compare
cguglielmo
reviewed
Jul 10, 2026
| import {ColumnLookupCall, DndTableFormWidgetMap} from '../../index'; | ||
| import model from './DndTableFormModel'; | ||
|
|
||
| export class DndTableForm extends Form { |
Member
There was a problem hiding this comment.
A separate form is fine to show some features, but please extend from HierarchicalTableForm instead of copying it.
Also add a checkbox to enable the rowsDraggable property to the TableProperties box so it is available for the other table forms too
| } | ||
|
|
||
| protected _onTableAcceptRowDrop(event: TableAcceptRowDropEvent) { | ||
| if (event.targetRow?.id === '2') { |
Member
There was a problem hiding this comment.
These rules are confusing, we should use reasonable cases.
confusing is for example: moving after row 2 is forbidden but before next row is allowed. Or moving inside 1 is forbidden but before or after children is allowed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
354650