Skip to content

[2319] Remove margins around the Actor image#2333

Open
jerome-obeo wants to merge 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/enh/remove_space_around_actor_image
Open

[2319] Remove margins around the Actor image#2333
jerome-obeo wants to merge 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/enh/remove_space_around_actor_image

Conversation

@jerome-obeo

@jerome-obeo jerome-obeo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Bug: #2319

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@AxelRICHARD AxelRICHARD added this to the 2026.7.0 milestone Jul 3, 2026
@AxelRICHARD AxelRICHARD linked an issue Jul 3, 2026 that may be closed by this pull request
Comment thread doc/content/modules/user-manual/assets/images/actor-new-shape.png
Comment thread doc/content/modules/user-manual/assets/images/actor-old-shape.png
Comment thread doc/content/modules/user-manual/assets/images/actor-old-shape.png
@jerome-obeo jerome-obeo force-pushed the jgo/enh/remove_space_around_actor_image branch from 14a5ec4 to 5a0b18d Compare July 3, 2026 12:52

@AxelRICHARD AxelRICHARD Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that when selected, we continue to see empty spaces on the left and right sides!
Do you think we could do something about that?
I was hoping that a selected Actor has no space on left and right sides, in the same way there is no space anymore on top and bottom sides now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dimensions was given through node description provider with olds values.

@jerome-obeo jerome-obeo force-pushed the jgo/enh/remove_space_around_actor_image branch 2 times, most recently from cc69d8e to 5a0b18d Compare July 3, 2026 14:30
Bug: eclipse-syson#2319
Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
@jerome-obeo jerome-obeo force-pushed the jgo/enh/remove_space_around_actor_image branch from 5a0b18d to 963d1c0 Compare July 3, 2026 16:54
@jerome-obeo jerome-obeo changed the title [2319] Remove vertical spacing in Actor image [2319] Remove margins around the Actor image Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Margin inside a svg shape

2 participants