Remove symfony/console, migrate console layer to entropy/entropy#27
Conversation
ECS no longer depends on symfony/console. The console layer runs on entropy/entropy: commands implement Entropy's CommandInterface (run() params are the CLI contract), and a new EasyCodingStandardStyle wraps entropy's OutputPrinter/ProgressBar. - commands (Check/Worker/ListCheckers) implement entropy CommandInterface; delete AbstractCheckCommand and the Symfony console application - replace SymfonyStyle with EasyCodingStandardStyle over entropy output; delete SymfonyStyleFactory - ConfigurationFactory builds Configuration from plain args instead of InputInterface; container resolves config from raw argv - ParallelFileProcessor passes plain option values to the decoupled WorkerCommandLineFactory (symplify/easy-parallel dev-main) - bin/ecs.php parses argv manually (xdebug, --version via Composer InstalledVersions, decoration-flag stripping, -c to --config) - drop dead Option CLI-name constants - composer: drop symfony/console from require, satisfy php-cs-fixer's constraint via replace; require easy-parallel dev-main
- CommandRegistrationTest: commands are discovered and wired into Entropy's CommandRegistry (check/worker/list-checkers registered, check is default, worker is hidden) - EasyCodingStandardStyleTest: Symfony console tags are translated into Entropy's OutputColorizer vocabulary (comment/info/options/closing)
|
I used the cli option '--config' to pass a custom config file. How is it handled after this migration ? I now get this error message: Run failed: Unknown option: "--config=" |
|
I think I found it: -c Is that correct ? |
|
Should be still |
|
Fixed in #46 |
|
Before we could add paths to check like so: |
|
The If it doesn't help, share full |
|
Alright, thanks. I'm sorry if i've missed it in the docs, but how should we add multiple paths to the ECS check? |
|
To use multiple paths, pass them as args: vendor/bin/ecs src testsBest practise is to use |
ECS no longer depends on symfony/console. The console layer runs on entropy/entropy: commands implement Entropy's CommandInterface (run() params are the CLI contract), and a new EasyCodingStandardStyle wraps entropy's OutputPrinter/ProgressBar.