Skip to content

[CLI 16] feat: add device-code OAuth login - #231

Merged
raviships merged 3 commits into
nextfrom
feat/cli-device-oauth
Aug 29, 2026
Merged

[CLI 16] feat: add device-code OAuth login#231
raviships merged 3 commits into
nextfrom
feat/cli-device-oauth

Conversation

@raviships

@raviships raviships commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • adds edgestore login --device using the OAuth device authorization grant
  • presents the one-time code before opening the verification page and polls until approval
  • stores cached OAuth registrations as flow-specific version 2 entries so browser and device clients are never reused across flows
  • keeps browser login as the default and management-token login available through --token

User impact

Users can log in from remote terminals or environments where a local OAuth callback is unavailable, while retaining the existing delegated permission and credential-storage behavior.

Validation

  • pnpm --filter @edgestore/cli test
  • pnpm --filter @edgestore/cli typecheck
  • pnpm --filter @edgestore/cli lint
  • pnpm --filter @edgestore/cli build
  • verified the device authorization server contract against the dev environment

The changeset is intentional because this adds a published CLI feature.

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
edgestore-docs Skipped Skipped Aug 29, 2026 7:30am
example-access-control Skipped Skipped Aug 29, 2026 7:30am
example-components Skipped Skipped Aug 29, 2026 7:30am

Request Review

@raviships
raviships marked this pull request as ready for review August 29, 2026 06:24
@raviships

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T07:40:04.196526Z 7db2277 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30a07ce36c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/core/oauth.ts Outdated
@vercel
vercel Bot temporarily deployed to Preview – edgestore-docs August 29, 2026 06:29 Inactive
@vercel
vercel Bot temporarily deployed to Preview – example-access-control August 29, 2026 06:29 Inactive
@vercel
vercel Bot temporarily deployed to Preview – example-components August 29, 2026 06:29 Inactive
@vercel
vercel Bot temporarily deployed to Preview – example-access-control August 29, 2026 07:30 Inactive
@vercel
vercel Bot temporarily deployed to Preview – example-components August 29, 2026 07:30 Inactive
@vercel
vercel Bot temporarily deployed to Preview – edgestore-docs August 29, 2026 07:30 Inactive
@raviships

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7db227715a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/commands/auth.ts
@raviships
raviships merged commit 7c0caac into next Aug 29, 2026
8 checks passed
@raviships
raviships deleted the feat/cli-device-oauth branch August 29, 2026 07:49
@github-actions github-actions Bot mentioned this pull request Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant