Accept empty watermaskfile and canopycoverfile in reconstructSWE - #7
Open
leonzcode wants to merge 1 commit into
Open
Accept empty watermaskfile and canopycoverfile in reconstructSWE#7leonzcode wants to merge 1 commit into
leonzcode wants to merge 1 commit into
Conversation
Both parameters default to [], but their validators required ischar, so explicitly passing the empty default errored. The WUS entry functions forward these arguments as [] when no files are supplied. Empty now validates and keeps its existing meaning: no canopy file (cc=zeros) and a water mask derived from the fSCA no-data cells. No behavior change when real filenames are passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional watermaskfile and canopycoverfile parameters default to [], but their validators only accept char. The WUS entry function passes [] when neither file is used, so the WY2025 Stage 2 run stopped during argument parsing.
This lets those two parameters accept empty values as intended. Real filenames behave as before.