Fix invalid HTML and make resume mobile-readable - #1
Open
eedeebee wants to merge 1 commit into
Open
Conversation
Structural and CSS-validity fixes only — no resume content changed. Markup bugs: - `<target="_blank" href="#">` was a malformed open tag (missing `a`), leaving Incremental Images' `</a>` orphaned. - Stray `</a>` closing a Clearwell `<li>` instead of `</li>`. - Clearwell's `<ul>` ran into `</div>` unclosed. - Orphaned `</li>` left over from a commented-out nested list in the MarkLogic section. CSS validity: - 12 `font-size` declarations had no unit (`font-size: 16`), which is invalid CSS and silently ignored by every browser. Now `16px` etc., so the intended type scale actually renders. Modernization: - HTML 4.01 Transitional doctype -> HTML5; added `lang="en"`. - Added viewport meta, so the page is legible on phones instead of rendering at desktop width and zooming out. - Replaced deprecated `<body link/vlink/alink>` with CSS `a:link`, `a:visited`, `a:active` using the identical colors. - Reduced `div` left padding at narrow widths so deeply nested sections don't lose usable line width on small screens. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural/CSS fixes to
EricBloch.html. No resume content was changed — I did not add, remove, or reword a single claim, date, or bullet.Markup bugs fixed
<target="_blank" href="#">— malformed open tag, missing thea<target>element; "Incremental Images, Inc." was not a link and its</a>was orphaned</a>where a Clearwell<li>should have closed<ul>ran into</div>unclosed</li>from a commented-out nested list (MarkLogic section)Verified with a tag-balance check: 5 structural errors before, 0 after.
CSS validity
12
font-sizedeclarations had no unit —font-size: 16,font-size: 22,font-size: 14,font-size: 12. Unitless lengths are invalid CSS (except0) and are silently dropped by every browser, so none of those sizes were being applied.pxmakes them take effect for the first time — your name renders at 22px, contact block at 14px, links at 12px. That is clearly what the markup intended, but it will look different from the page live today. Worth a look before merging; happy to drop this part if you'd rather keep current rendering.Modernization
lang="en"<meta name="viewport">— the page had none, so phones rendered it at desktop width and zoomed out<body link/vlink/alink>→ CSSa:link/a:visited/a:active, identical colors (#000099,#990099)divleft padding from 30px to 12px, so deeply nested sections keep usable line width on phonesNot touched, but you should know
Your home address and phone number are published in this public repo —
15 Miranda Court, Hillsborough, CA 94010and650-339-0376, live at bloch.family and indexable. Standard practice on a public resume is to drop both and keep email/LinkedIn. I deliberately did not change this: it's a content and privacy call that's yours, not a bug fix. Say the word and it's a one-line follow-up.Two other things I noticed and left alone:
index.htmlis still aHELLO WORLDplaceholder, and this repo's GitHubhomepageUrlsaysvirginia-avenue.comwhileCNAMEsaysbloch.family.🤖 Generated with Claude Code