Generalise S3 buckets - #14
Open
tonytw1 wants to merge 46 commits into
Open
Conversation
tonytw1
force-pushed
the
multi-tenant
branch
from
February 12, 2025 17:58
d1684a8 to
ea199a8
Compare
tonytw1
force-pushed
the
gcp-storage-buckets
branch
6 times, most recently
from
February 15, 2025 12:35
af00e4e to
831d946
Compare
tonytw1
force-pushed
the
gcp-storage-buckets
branch
3 times, most recently
from
February 26, 2025 21:07
f875471 to
23e97d6
Compare
tonytw1
force-pushed
the
gcp-storage-buckets
branch
2 times, most recently
from
March 13, 2025 21:18
dfeea9c to
74792d0
Compare
tonytw1
force-pushed
the
gcp-storage-buckets
branch
9 times, most recently
from
April 14, 2025 21:30
01f28c6 to
af87d7e
Compare
tonytw1
force-pushed
the
gcp-storage-buckets
branch
8 times, most recently
from
April 20, 2025 16:56
12bf2c0 to
a9d3863
Compare
… reference to the presigner. presigner is private.
Cannot see a reason why you'd not set this; cropping is not an optional feature.
… and use path style URLs parameters rather than isDev and useLocalAuth.
…int and use path style URLs parameters rather than localstackAware.
Use client and presigners attached to the S3Bucket. Left as String deliberately: ImageLoaderConfig.maybeImageReplicaBucket — it drives a raw replicaS3: S3Client, not the S3/S3Bucket abstraction. Same for panda/permissions provider buckets.
…oses raw S3Client.
Upload bucket connectSource is supplied by the bucket object; knows about path style bucket URLs. Kahuna UI can connect to ingest bucket endpoint.
Fixes Unsupported mime type text/plain; charset=UTF-8 regression in KeyStore loading API keys. SDK v2 behaviour around auto-detection is different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Expands the concept of an S3 bucket from just the bucket name to a case class fully describing the bucket.
Allows GCP and locally hosted buckets to be used in addition to AWS.
Introduces an
S3Bucketclass to fully describe a bucket.The definition of a bucket in configuration moves from bucket name to a triple of name, end point and URL style.
ie.
Decisions about URLs of buckets and keys move to the
S3Bucketclass which has now enough knowledge to determine this.How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?