Libvips cropping - #16

Draft

tonytw1 wants to merge 79 commits into

libvips-cropping

Commits on Sep 2, 2026

Spike; create master crop file via vips.
tonytw1
committed
b1dee01
Naive resize crops to jpegs only step.
tonytw1
committed
46bafb9

Commits on Sep 3, 2026

Delete unused ImageOperations.resizeImage.
tonytw1
committed
0c4ed22
createCrops and resizeImageVips in same Future and arena to allow sharing of source image.
tonytw1
committed
cd2f496
Try to use 1 load of the source image across all resizes; do the resizes mutate the source?
tonytw1
committed
0cfafd6
createCrops takes the masterCrop as a VImage rather than a file.
tonytw1
committed
c0e6783
createMasterCrop moving to same arena.
tonytw1
committed
39bb969
Remove colourModel check from createMasterCrop.
tonytw1
committed
e10c306
Logging. Show when we reload the master crop from disk.
tonytw1
committed
1f631a4
Correct arena close timing.
tonytw1
committed
14b13f4
createMasterCrop no Futures.
tonytw1
committed
e4fd4ae
arena scope?
tonytw1
committed
98b49ca
arena scope?
tonytw1
committed
703c320
arena scope?
tonytw1
committed
05d6a82
arena scope?
tonytw1
committed
b41aff8
Spike; no reload of master crop image.
tonytw1
committed
04a8abf
Marking TODO; why local file for master crop.
tonytw1
committed
f3d8393
Log local resize file location.
tonytw1
committed
47bbd21
PNG specific optimiseImage steps can move straight into the resizeImageVips VIPS save.
tonytw1
committed
3ab685a
Delete unused ImageOperations.optimiseImage.
tonytw1
committed
44d156f
Remove pnquant from base image.
tonytw1
committed
9e50b53
Logging.
tonytw1
committed
9ace9ab
TODO Strip true is needed to stop exif auto correction until we can strip metadata with vips.
tonytw1
committed
35cb712
Revert "Revert "Master image converted to sRBG colour space.""
tonytw1
committed
c3572b8
Resize uses save file.
tonytw1
committed
8220ab0
Log crop type decision.
tonytw1
committed
1876626
Colour correct not effective if metadata stripped. Bake it in?
tonytw1
committed
ff6e2b0
Refactor; master crop image file write pushes up out of the create master image.
tonytw1
committed
bd6a87f
createMasterCrop uses saveToFile and can now save PNGs.
tonytw1
committed
2551121
Refactor. S3 store of master crop pushes up. MasterCrop is a simpler opject with no Futures in it.
tonytw1
committed
db841f1
Refactor. File create for mastercrop pushes up to be next to the s3 store.
tonytw1
committed
995a6f1
Master file create order; before arena close.
tonytw1
committed
63f8a01
Comment; master crop if different from the the full dimensions crop; it's higher quality for CDN resizer origin.
tonytw1
committed
311c552
Refactor; split creation of crop files from publishing to S3.
tonytw1
committed
a8dbaea
quantise crops.
tonytw1
committed
bde3ff1
isGraphic was sendint all TIFFs to PNG.
tonytw1
committed
663cc70
isGraphic was sendint all TIFFs to PNG.
tonytw1
committed
70e01ef
Correct CMYK renders too light in crops.
tonytw1
committed
fd093e5
Unused parameters.
tonytw1
committed
c8b42ec
Unused parameters.
tonytw1
committed
97ebdc2
Bypass icc_transform for LAB images.
tonytw1
committed
77ebd08
Remove non used non vips functions.
tonytw1
committed
087ae6c
Remove non used runConvert command.
tonytw1
committed
8c9f40f
Remove unused iccColourSpace val.
tonytw1
committed
e1a5ca6
Reapply png master quality.
tonytw1
committed
0a360e1
Crop quality values can be int.
tonytw1
committed
c1974d7
CropType decision can be deferred until after the master crop has been loaded.
tonytw1
committed
7ee684b
Refactor. Push the isGraphic? decision up out of cropType so that is can be made at a more implementation specific level.
tonytw1
committed
2795446
Spike. vips based implementation of isGraphic? is likely to involve the number of bands in the image.
tonytw1
committed
f1d9e1c
[libvips] Testing around hasAlpha.
tonytw1
committed
b8107a4
Test to exercise ImageOperations resize.
tonytw1
committed
48c28b1
Clarify master crop quality values.
tonytw1
committed
3c49edb
[libvips-cropping] Allow embedded icc profile to be used in crop icc transform.
tonytw1
committed
eb30d50
[libvips-cropping] Image operations resize takes the output file as a parameter for easier testing.
tonytw1
committed
5822935
[libvips-cropping] Cropping of LAB fixed by making non icc_transform decision based on no icc profile seen.
tonytw1
committed
92ce9a8
[libvips-cropping] Additional resize tests.
tonytw1
committed
9473298
[crop-metadata] Show that it is possible to manually trim metadata without relying in strip on save.
tonytw1
committed
8b5a60f
[crop-metadata] Bake the credit, copyright and supplier transmission reference into the XMP using IPTC metadata fields.
tonytw1
committed
f59842d
[crop-metadata] While manually stripping metadata might be useful, vips strip with keep for XMP feels safer.
tonytw1
committed
984d1ec
[crop-metadata] Crop metadata in XMP via vips removes exiftool as a dependency.
tonytw1
committed
f16dd9d
Remove exiftool from base image.
tonytw1
committed
8a249b7
[libvips-cropping] Test for correct resize of png with alpha.
tonytw1
committed
4fb8009
[libvips-cropping] Provide an example of the vips can't render a LAB tiff with alpha correctly.
tonytw1
committed
ff6dc1c
[libvips-cropping] Cleanup; Lower the input of apiSource to imageId for outputFilename.
tonytw1
committed
262d003
[libvips-cropping] resizeImageVips does not need the MasterCrop object
tonytw1
committed
ea32c7c
[libvips-cropping] Metadata for crop call.
tonytw1
committed
6870486
[libvips-cropping] createCrops moves to image operations for testing.
tonytw1
committed
3f4459e
[libvips-cropping] Tests to exercise crops.
tonytw1
committed
a0a96f9
[libvips-cropping] createCrops can execute it's resizeImage calls in parallel.
tonytw1
committed
5b52860
[libvips-cropping] Master crop save in parallel.
tonytw1
committed
9f28a08
[libvips-cropping] Logging.
tonytw1
committed
d2e5224
[libvips-cropping] Logging and imports.
tonytw1
committed
6a3383f
[libvips-cropping] Do not send resizes until master has successfully rendered; don't want to send partial sets.
tonytw1
committed
42141b3
[libvips-cropping] getImageInformation uses imageOperations.hasAlpha function
tonytw1
committed
3bc7692
[libvips-cropping] Crops uses master hasAlpha image operation rather than indexed metadata for crop type decision.
tonytw1
committed
99f4c37
[libvips-cropping] Do not repeat calls to image_get_interpretation
tonytw1
committed
f689048
CropsTest - wait for Future before closing arena!
tonytw1
committed
c9a054d
[libvips] Remove runIdentifyCmd and it's unused upsteams fromIPTCHeadersWithColorInfo and fromIPTCHeadersWithColorInfo.
tonytw1
committed
b88ddb6
[containerised] Remove graphicsmagick from the base image.
tonytw1
committed
f5d2e30