chore(repo): switch package manager references from pnpm to utoo#5959
Open
killagu wants to merge 15 commits into
Open
chore(repo): switch package manager references from pnpm to utoo#5959killagu wants to merge 15 commits into
killagu wants to merge 15 commits into
Conversation
Replace `pnpm` with `utoo` across docs, top-level scripts, and CI
workflows. Lockfile / workspace filenames (`pnpm-lock.yaml`,
`pnpm-workspace.yaml`) and the `ut install --from pnpm` flag value
are preserved because they refer to real artifacts on disk and to a
CLI argument, not to a tool invocation.
- AGENTS.md, README.md/README.zh-CN.md, packages/egg/README.md,
tools/create-egg/README.md, plugins/redis/README.md,
wiki/concepts/repository-map.md, tegg/CLAUDE.md,
.github/copilot-instructions.md: rewrite command snippets and prose.
- package.json: bump `packageManager` to `utoo@1.0.28`.
- scripts/{publish,version,utils}.js: invoke `utoo` instead of
`pnpm` and update comments.
- .github/workflows/release.yml, .github/workflows/e2e-test.yml:
swap pnpm/action-setup for utooland/setup-utoo and call `ut` / `utoo`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR replaces pnpm with utoo/ut across the repo: updates package.json, GitHub Actions (release and E2E), adds a pack-all script, adjusts publish/version scripts, and converts developer- and user-facing documentation and examples to utoo/ut commands. ChangesPackage Manager Migration from pnpm to utoo
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the monorepo's package manager from pnpm to utoo across configuration files, scripts, and documentation. The review feedback points out a version mismatch in the Copilot instructions file, where the specified utoo version (v10.16.0) does not match the version configured in package.json (1.0.28), and provides a suggestion to correct it.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| - **Node.js >= 20.19.0 required** - This is a hard requirement | ||
| - Enable pnpm first: `corepack enable pnpm` (installs pnpm v10.16.0) | ||
| - Enable utoo first: `corepack enable utoo` (installs utoo v10.16.0) |
Contributor
There was a problem hiding this comment.
The version of utoo specified here (v10.16.0) is outdated and does not match the version configured in package.json (1.0.28). It should be updated to reflect the correct version.
Suggested change
| - Enable utoo first: `corepack enable utoo` (installs utoo v10.16.0) | |
| - Enable utoo first: `corepack enable utoo` (installs utoo v1.0.28) |
Contributor
Author
There was a problem hiding this comment.
Fixed in 26b1a40 — bumped to v1.0.28 to match package.json's packageManager field.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## next #5959 +/- ##
===========================================
- Coverage 85.30% 65.21% -20.09%
===========================================
Files 670 1 -669
Lines 19552 23 -19529
Branches 3863 9 -3854
===========================================
- Hits 16678 15 -16663
+ Misses 2481 7 -2474
+ Partials 393 1 -392 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository-facing documentation, scripts, and CI workflows to reference utoo instead of pnpm, aligning contributor guidance and automation with the project’s actual package manager usage while preserving pnpm-specific artifact filenames/flags where required (e.g., pnpm-workspace.yaml, ut install --from pnpm).
Changes:
- Replace pnpm CLI references with
utoo/utacross root/package/plugin docs and agent guidance. - Update root
packageManagertoutoo@1.0.28and switch release utility scripts to invokeutoo. - Update GitHub Actions workflows (release + e2e) to use
utooland/setup-utooandut/utoocommands.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| wiki/concepts/repository-map.md | Updates wiki description of the monorepo package manager to utoo. |
| tools/create-egg/README.md | Updates scaffolding instructions to use utoo create egg. |
| tegg/CLAUDE.md | Updates tegg contributor commands from pnpm to utoo. |
| scripts/version.js | Updates dry-run guidance output to suggest utoo run version:*. |
| scripts/utils.js | Updates comment to refer to utoo workspace (still reads pnpm-workspace.yaml). |
| scripts/publish.js | Switches publish implementation from invoking pnpm to invoking utoo. |
| README.zh-CN.md | Updates quickstart commands to utoo. |
| README.md | Updates quickstart/monorepo commands and descriptions to utoo. |
| plugins/redis/README.md | Updates plugin test command to utoo. |
| packages/egg/README.md | Updates quickstart commands and notes to utoo. |
| package.json | Sets packageManager to utoo@1.0.28. |
| AGENTS.md | Updates agent guidance and core commands from pnpm to utoo. |
| .github/workflows/release.yml | Uses setup-utoo and ut install --from pnpm, updates build step to ut run build. |
| .github/workflows/e2e-test.yml | Uses setup-utoo and utoo/ut commands; adjusts publint pack env var (needs follow-up). |
| .github/copilot-instructions.md | Updates Copilot guidance from pnpm to utoo (contains version/engine mismatches). |
Comment on lines
+157
to
+161
| # publint pack defaults to npm (main CI env has no utoo); in E2E we | ||
| # already have utoo installed and npm pack against utoo's symlinked | ||
| # node_modules is ~10x slower, so prefer utoo pack here | ||
| PUBLINT_PACK: utoo | ||
| run: ut run build |
Contributor
Author
There was a problem hiding this comment.
Good catch — this was the actual cause of the failing E2E checks. Fixed in 26b1a40 by removing the PUBLINT_PACK: utoo env var so publint falls back to its default npm pack, matching the main CI environment.
Comment on lines
+13
to
+14
| - **Node.js >= 20.19.0 required** - This is a hard requirement | ||
| - Enable pnpm first: `corepack enable pnpm` (installs pnpm v10.16.0) | ||
| - Enable utoo first: `corepack enable utoo` (installs utoo v10.16.0) |
Contributor
Author
There was a problem hiding this comment.
Both mismatches fixed in 26b1a40 — Node bumped to >=22.18.0 and utoo to v1.0.28 to track package.json's engines and packageManager fields.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/publish.js (1)
56-71:⚠️ Potential issue | 🔴 Critical | 🏗️ Heavy liftFix utoo publish flag compatibility in scripts/publish.js
scripts/publish.jsbuildsutoo --filter <pkg> publish --no-git-checks --access public --tag <npmTag> [--provenance] [--dry-run], but utoo’spublishcommand documents only--tag,--dry-run, and--otp—so the extra flags (--filter,--no-git-checks,--access, and conditional--provenance) are likely unsupported and can break publishing (the script retries once and exitsprocess.exit(1)if anything still fails).e2e-test.ymlonly usesutoo -r pack, so the same publish-flag issue doesn’t apply there.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/publish.js` around lines 56 - 71, publishOne(pkg) is passing unsupported utoo flags (--filter, --no-git-checks, --access, --provenance) which can break publish; remove those flags and instead invoke utoo's publish command from the package's own directory so workspace context is preserved. Update publishOne(pkg) to call execFileSync('utoo', ['publish', '--tag', npmTag, ...(isDryRun ? ['--dry-run'] : []), ...(otpValue ? ['--otp', otpValue] : [])], { cwd: pkgDir /* use the package's directory property */, stdio: 'inherit', env: { ...process.env, NPM_CONFIG_LOGLEVEL: 'verbose' }, timeout: 120000 }); — keep npmTag, isDryRun, baseDir references as needed but set cwd to the package path and drop --filter, --no-git-checks, --access, and --provenance.
🧹 Nitpick comments (3)
AGENTS.md (1)
21-27: ⚡ Quick winAdd explicit
corepack enable utoobefore command list.Please include the enable step before
utoo installin the canonical command section to avoid bootstrap failures on clean machines.Based on learnings: "Enable utoo first with 'corepack enable utoo' before running install and build commands in the monorepo".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AGENTS.md` around lines 21 - 27, Add an explicit "corepack enable utoo" step before the listed canonical commands: update the AGENTS.md command section so the first step is to run corepack enable utoo (preceding the `utoo install`, `utoo run build`, `utoo run test`, `utoo run lint`, and `utoo run typecheck` entries) and ensure any example usage (e.g., `utoo --filter=egg run test` / `utoo --filter=site run dev`) remains unchanged and follows the install/build steps.scripts/version.js (1)
124-124: 💤 Low valueMinor: align command alias with the rest of the repo.
This prints
utoo run version:..., whilepackage.jsonscripts and the workflows consistently use theutalias (e.g.ut run build). Considerut run version:${versionType}for consistency in user-facing guidance. Functionally equivalent if both aliases are installed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/version.js` at line 124, The console.log in scripts/version.js currently prints "utoo run version:${versionType}" which is inconsistent with the repo's alias; update the message in the console.log call to use the "ut" alias instead (e.g. "ut run version:${versionType}") so the user-facing guidance matches package.json scripts and workflows; locate the console.log statement that references versionType and replace the displayed command string accordingly..github/workflows/release.yml (1)
65-66: 💤 Low valueClarify the
setup-utooref comment (SHA pin is already sufficient)File: .github/workflows/release.yml
Lines: 65-66- name: Setup utoo uses: utooland/setup-utoo@3a51006d0b66afcc32d1b9177a4b200b74f4a8cb # mainThe step is already pinned to an immutable commit SHA, so it’s not “tracking”
mainin practice. The# maincomment is potentially misleading, and this specific commit doesn’t appear to be publicly associated with a named release tag in theutooland/setup-utoorepo. Either update the comment to match the actual upstream ref you intend, or drop it; if you specifically want the latestv1release, pin to that release tag’s commit instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yml around lines 65 - 66, The comment after the uses line for the "Setup utoo" step is misleading because the action is already pinned to a commit SHA; either remove the trailing "# main" comment or replace it with the actual intended upstream ref (e.g., the release tag or branch name) or pin to the release tag commit (e.g., v1) instead; update the line that references utooland/setup-utoo@3a51006d0b66afcc32d1b9177a4b200b74f4a8cb (the uses entry for the "Setup utoo" step) accordingly so the comment accurately reflects the chosen ref or is removed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@scripts/publish.js`:
- Around line 56-71: publishOne(pkg) is passing unsupported utoo flags
(--filter, --no-git-checks, --access, --provenance) which can break publish;
remove those flags and instead invoke utoo's publish command from the package's
own directory so workspace context is preserved. Update publishOne(pkg) to call
execFileSync('utoo', ['publish', '--tag', npmTag, ...(isDryRun ? ['--dry-run'] :
[]), ...(otpValue ? ['--otp', otpValue] : [])], { cwd: pkgDir /* use the
package's directory property */, stdio: 'inherit', env: { ...process.env,
NPM_CONFIG_LOGLEVEL: 'verbose' }, timeout: 120000 }); — keep npmTag, isDryRun,
baseDir references as needed but set cwd to the package path and drop --filter,
--no-git-checks, --access, and --provenance.
---
Nitpick comments:
In @.github/workflows/release.yml:
- Around line 65-66: The comment after the uses line for the "Setup utoo" step
is misleading because the action is already pinned to a commit SHA; either
remove the trailing "# main" comment or replace it with the actual intended
upstream ref (e.g., the release tag or branch name) or pin to the release tag
commit (e.g., v1) instead; update the line that references
utooland/setup-utoo@3a51006d0b66afcc32d1b9177a4b200b74f4a8cb (the uses entry for
the "Setup utoo" step) accordingly so the comment accurately reflects the chosen
ref or is removed.
In `@AGENTS.md`:
- Around line 21-27: Add an explicit "corepack enable utoo" step before the
listed canonical commands: update the AGENTS.md command section so the first
step is to run corepack enable utoo (preceding the `utoo install`, `utoo run
build`, `utoo run test`, `utoo run lint`, and `utoo run typecheck` entries) and
ensure any example usage (e.g., `utoo --filter=egg run test` / `utoo
--filter=site run dev`) remains unchanged and follows the install/build steps.
In `@scripts/version.js`:
- Line 124: The console.log in scripts/version.js currently prints "utoo run
version:${versionType}" which is inconsistent with the repo's alias; update the
message in the console.log call to use the "ut" alias instead (e.g. "ut run
version:${versionType}") so the user-facing guidance matches package.json
scripts and workflows; locate the console.log statement that references
versionType and replace the displayed command string accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 595a3cf3-75db-4a32-bb14-923d1891e117
📒 Files selected for processing (15)
.github/copilot-instructions.md.github/workflows/e2e-test.yml.github/workflows/release.ymlAGENTS.mdREADME.mdREADME.zh-CN.mdpackage.jsonpackages/egg/README.mdplugins/redis/README.mdscripts/publish.jsscripts/utils.jsscripts/version.jstegg/CLAUDE.mdtools/create-egg/README.mdwiki/concepts/repository-map.md
…sions - E2E `Build all packages` was failing because `PUBLINT_PACK: utoo` is not in publint's supported set (`npm | pnpm | yarn | bun`). Falling back to the default (`npm`) so publint's per-package pack succeeds again, matching the main CI environment. - Align `.github/copilot-instructions.md` Node and utoo versions with the values declared in `package.json` (`engines.node >=22.18.0`, `packageManager: utoo@1.0.28`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- scripts/publish.js: invoke `utoo publish` from each package's own directory so utoo's supported flag set works. Drop pnpm-only flags (`--filter`, `--no-git-checks`); keep the npm-standard `--access` and `--provenance` flags that utoo forwards to npm. - AGENTS.md: prepend `corepack enable utoo` to the canonical commands so a clean machine boots into the pinned utoo version. - scripts/version.js: print the `ut run version:<type>` alias used by the rest of the repo (workflows + package.json scripts). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@coderabbitai thanks — addressed in 8a96e3e:
|
Contributor
|
Tip For best results, initiate chat on the files or code changes.
🐇 ✨ |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
.github/copilot-instructions.md (3)
95-95:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCommand inconsistency in development workflow and validation sections.
Multiple locations still reference
utoo run <script>instead ofut run <script>:
- Line 95: Build instruction in "Making Changes"
- Lines 111-120: All validation step commands
- Line 181: Build reminder in "Build Issues"
- Lines 220-223: All validation scenario commands
🔧 Proposed fix
### 1. Making Changes -- Always build packages first: `utoo run build` +- Always build packages first: `ut run build` - Work primarily in `packages/egg/src/` for core framework features**Always perform these validation steps after making changes:** ```bash # 1. Build all packages (required) -utoo run build +ut run build # 2. Run linting -utoo run lint +ut run lint # 3. Run tests (some failures are expected in fresh environment) -utoo run test +ut run test # 4. Test documentation site -utoo run site:dev +ut run site:dev```diff ### Build Issues -- Always run `utoo run build` after making changes +- Always run `ut run build` after making changes - TypeScript compilation errors will show clearlyAfter making changes, always verify: -1. **Build Success**: `utoo run build` completes without errors -2. **Linting Passes**: `utoo run lint` shows no new errors -3. **Documentation Loads**: `utoo run site:dev` starts successfully and site loads at http://localhost:8000 -4. **Tests Run**: `utoo run test` executes (some failures expected, focus on your changes) +1. **Build Success**: `ut run build` completes without errors +2. **Linting Passes**: `ut run lint` shows no new errors +3. **Documentation Loads**: `ut run site:dev` starts successfully and site loads at http://localhost:8000 +4. **Tests Run**: `ut run test` executes (some failures expected, focus on your changes)Also applies to: 111-120, 181-181, 220-223
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/copilot-instructions.md at line 95, Replace incorrect developer commands that use "utoo run <script>" with the correct "ut run <script>" throughout the document; specifically update each occurrence of "utoo run build", "utoo run lint", "utoo run test", and "utoo run site:dev" to "ut run build", "ut run lint", "ut run test", and "ut run site:dev" respectively (these tokens identify the locations to change).
82-89:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCommand inconsistency in package-specific commands.
Examples use
utoo --filter=<package>but should useut --filter=<package>to match actual repository commands.🔧 Proposed fix
-Run commands for specific packages using `utoo --filter=<package>`: +Run commands for specific packages using `ut --filter=<package>`: ```bash # Examples -utoo --filter=egg run test -utoo --filter=`@eggjs/core` run build -utoo --filter=site run dev +ut --filter=egg run test +ut --filter=`@eggjs/core` run build +ut --filter=site run dev</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In @.github/copilot-instructions.md around lines 82 - 89, Update the example
commands in .github/copilot-instructions.md to use the correct CLI name: replace
all occurrences of "utoo --filter=" with "ut --filter=" in the
three example lines (the examples currently showing "utoo --filter=egg run
test", "utoo --filter=@eggjs/corerun build", and "utoo --filter=site run dev");
ensure the rest of each example (flags and subcommands) remains unchanged.</details> --- `57-78`: _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_ **Command inconsistency in build, test, lint, and documentation sections.** All command examples use `utoo run <script>`, but should use `ut run <script>` to match the actual repository commands. Additionally, **line 73** has a hybrid command that doesn't match the repository scripts: - Current: `cd site && utoo run build:skip` - package.json line 34: `"site:build": "cd site && npm run build"` - Should be: `ut run site:build` (from root) to match line 222 <details> <summary>🔧 Proposed fix</summary> ```diff ### Build Commands -- `utoo run build` - **Build all packages (~14 seconds). NEVER CANCEL. Set timeout to 60+ seconds.** -- `utoo run clean` - Clean all dist directories +- `ut run build` - **Build all packages (~14 seconds). NEVER CANCEL. Set timeout to 60+ seconds.** +- `ut run clean` - Clean all dist directories ### Testing Commands -- `utoo run test` - **Run all tests (~2 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** -- `utoo run test:cov` - **Run tests with coverage (~2 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** -- `utoo run ci` - **Run test coverage + build (~2.1 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** +- `ut run test` - **Run all tests (~2 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** +- `ut run test:cov` - **Run tests with coverage (~2 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** +- `ut run ci` - **Run test coverage + build (~2.1 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** ### Linting Commands -- `utoo run lint` - Run oxlint across all packages (~2 seconds) +- `ut run lint` - Run oxlint across all packages (~2 seconds) ### Documentation Commands -- `utoo run site:dev` - Start documentation dev server at http://localhost:8000 -- `cd site && utoo run build:skip` - **Build documentation site (~24 seconds). NEVER CANCEL. Set timeout to 60+ seconds.** +- `ut run site:dev` - Start documentation dev server at http://localhost:8000 +- `ut run site:build` - **Build documentation site (~24 seconds). NEVER CANCEL. Set timeout to 60+ seconds.** ### Example Applications (Currently Not Working) -- `utoo run example:commonjs` - Start CommonJS example (has runtime issues) -- `utoo run example:typescript` - Start TypeScript example (has runtime issues) +- `ut run example:commonjs` - Start CommonJS example (has runtime issues) +- `ut run example:typescript` - Start TypeScript example (has runtime issues)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/copilot-instructions.md around lines 57 - 78, The docs use the wrong npm-run prefix "utoo run" and one hybrid command; update all occurrences to the correct "ut run" form (e.g., change `utoo run build`, `utoo run clean`, `utoo run test`, `utoo run test:cov`, `utoo run ci`, `utoo run lint`, `utoo run site:dev`, `utoo run example:commonjs`, `utoo run example:typescript`) and replace the hybrid `cd site && utoo run build:skip` with the canonical root command `ut run site:build` to match the repository scripts (referencing the script names site:build and site:dev).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/copilot-instructions.md:
- Line 14: The docs reference the wrong CLI name and a potentially invalid
Corepack step; replace all occurrences of "utoo" with "ut" (e.g., change
"corepack enable utoo" and "utoo run build:skip" to use "ut"), and update the
bootstrap instruction to a valid Corepack/installer step for this repo (either
remove "corepack enable utoo" and use a generic "corepack enable" plus the
recommended prepare/activate step for the package manager, or explicitly
document installing/activating the "ut" shim), and ensure the example command
referencing "build:skip" maps to the real npm script (e.g., "ut run site:build"
or "ut run build:skip" only if that script exists in package.json).
---
Outside diff comments:
In @.github/copilot-instructions.md:
- Line 95: Replace incorrect developer commands that use "utoo run <script>"
with the correct "ut run <script>" throughout the document; specifically update
each occurrence of "utoo run build", "utoo run lint", "utoo run test", and "utoo
run site:dev" to "ut run build", "ut run lint", "ut run test", and "ut run
site:dev" respectively (these tokens identify the locations to change).
- Around line 82-89: Update the example commands in
.github/copilot-instructions.md to use the correct CLI name: replace all
occurrences of "utoo --filter=<package>" with "ut --filter=<package>" in the
three example lines (the examples currently showing "utoo --filter=egg run
test", "utoo --filter=`@eggjs/core` run build", and "utoo --filter=site run dev");
ensure the rest of each example (flags and subcommands) remains unchanged.
- Around line 57-78: The docs use the wrong npm-run prefix "utoo run" and one
hybrid command; update all occurrences to the correct "ut run" form (e.g.,
change `utoo run build`, `utoo run clean`, `utoo run test`, `utoo run test:cov`,
`utoo run ci`, `utoo run lint`, `utoo run site:dev`, `utoo run
example:commonjs`, `utoo run example:typescript`) and replace the hybrid `cd
site && utoo run build:skip` with the canonical root command `ut run site:build`
to match the repository scripts (referencing the script names site:build and
site:dev).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fc2d5ec3-7eaf-4f97-801d-8b5fd308edfb
📒 Files selected for processing (2)
.github/copilot-instructions.md.github/workflows/e2e-test.yml
💤 Files with no reviewable changes (1)
- .github/workflows/e2e-test.yml
Comment on lines
+57
to
+58
| - `utoo run build` - **Build all packages (~14 seconds). NEVER CANCEL. Set timeout to 60+ seconds.** | ||
| - `utoo run clean` - Clean all dist directories |
Contributor
Author
There was a problem hiding this comment.
Fixed in 585d981 — changed to ut run clean-dist to match the actual root script. (Also caught example:commonjs/example:typescript → example:dev:commonjs/example:dev:typescript while in the same file.)
| pnpm run build # Build all packages including tegg (runs build in all workspaces) | ||
| pnpm run clean # Clean all build artifacts including tegg (removes dist, tsbuildinfo) | ||
| utoo run build # Build all packages including tegg (runs build in all workspaces) | ||
| utoo run clean # Clean all build artifacts including tegg (removes dist, tsbuildinfo) |
Contributor
Author
There was a problem hiding this comment.
Fixed in 585d981 — ut run clean → ut run clean-dist to match the root script.
utoo doesn't implement pnpm's recursive `-r pack`, so the E2E "Pack packages into tgz" step was failing with `error: unexpected argument '-r' found`. Replace it with a small node script that reuses the publish-script's package discovery and runs `npm pack --pack-destination <repoRoot>` per publishable package, matching the tgz layout `ecosystem-ci/patch-project.ts` expects (repo-root-relative file:// overrides). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/pack-all.js (1)
14-14: ConfirmgetPublishablePackagesreturns{ directory, folder }
scripts/utils.jsexportsgetPublishablePackages(baseDir)and it builds/pushes package objects containing bothfolderanddirectory(also throwing a clear error ifpnpm-workspace.yamlis missing). This matches whatscripts/pack-all.jsexpects when forming thecwdfornpm pack.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/pack-all.js` at line 14, Confirm that the function getPublishablePackages in scripts/utils.js returns objects containing both properties named directory and folder (and throws a clear error if pnpm-workspace.yaml is missing), because scripts/pack-all.js uses those keys to form the cwd for the npm pack call; if the function does not return both fields or the error behavior differs, update getPublishablePackages to include both directory and folder on each package object and to throw a descriptive error when pnpm-workspace.yaml is absent so pack-all.js can safely use pkg.directory and pkg.folder when constructing the npm pack cwd.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/pack-all.js`:
- Line 14: Confirm that the function getPublishablePackages in scripts/utils.js
returns objects containing both properties named directory and folder (and
throws a clear error if pnpm-workspace.yaml is missing), because
scripts/pack-all.js uses those keys to form the cwd for the npm pack call; if
the function does not return both fields or the error behavior differs, update
getPublishablePackages to include both directory and folder on each package
object and to throw a descriptive error when pnpm-workspace.yaml is absent so
pack-all.js can safely use pkg.directory and pkg.folder when constructing the
npm pack cwd.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1abed799-6af9-4876-9aec-d555acaf3b2c
📒 Files selected for processing (2)
.github/workflows/e2e-test.ymlscripts/pack-all.js
CodeRabbit / Copilot caught that the docs reference \`utoo run …\`
while package.json scripts and CI workflows all use the \`ut\` alias,
and some referenced root scripts (\`clean\`, \`build:skip\`,
\`example:commonjs\`/\`example:typescript\`) don't exist.
- Rewrite \`utoo install/run/create/test/pack/publish/--filter/-r\` to
the matching \`ut …\` form in README.md, README.zh-CN.md,
packages/egg/README.md, tools/create-egg/README.md,
plugins/redis/README.md, tegg/CLAUDE.md, AGENTS.md,
.github/copilot-instructions.md, scripts/publish.js, and
scripts/dev-services.js. Keep the \`utoo\` package name (corepack,
\`packageManager\`, prose) intact.
- Fix script name drift: \`ut run clean\` → \`ut run clean-dist\`,
\`ut run build:skip\` → \`ut run build\`,
\`ut run example:{commonjs,typescript}\` → \`ut run example:dev:{commonjs,typescript}\`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`ut pm-pack` does not yet resolve `workspace:` / `catalog:` protocols inside the packed manifests, so downstream `npm install` in the ecosystem-ci projects fails with `EUNSUPPORTEDPROTOCOL`. `npm pack` has the same limitation, which is why the previous attempt with scripts/pack-all.js also broke. Keep pnpm available just for the pack step and drop the unused scripts/pack-all.js. The rest of the workflow stays on utoo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Comment on lines
+62
to
+64
| - `ut run test` - **Run all tests (~2 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** | ||
| - `ut run test:cov` - **Run tests with coverage (~2 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** | ||
| - `ut run ci` - **Run test coverage + build (~2.1 minutes). NEVER CANCEL. Set timeout to 180+ seconds.** |
Contributor
Author
There was a problem hiding this comment.
Fixed in 2a4c085 — ut run ci description now matches the actual script (ut run test -- --coverage, no build).
Comment on lines
+72
to
+73
| - `ut run site:dev` - Start documentation dev server at http://localhost:8000 | ||
| - `cd site && ut run build` - **Build documentation site (~24 seconds). NEVER CANCEL. Set timeout to 60+ seconds.** |
Contributor
Author
There was a problem hiding this comment.
Fixed in 2a4c085 — dropped the localhost:8000 claim (VitePress picks its own port), and switched the build invocation to the root ut run site:build script.
| import yaml from 'js-yaml'; | ||
|
|
||
| // Get all publishable packages from pnpm workspace | ||
| // Get all publishable packages from utoo workspace |
Contributor
Author
There was a problem hiding this comment.
Clarified in 2a4c085 — comment now states explicitly that utoo reads the existing pnpm-workspace.yaml, matching the code.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/publish.js (1)
93-109:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDry-run publish errors never fail the script.
When
isDryRunis true, this catch path still queues the package intoRetry, but the retry block is skipped by&& !isDryRun. That leavesfinalFailedempty, so the script prints a successful summary and exits 0 even ifut publish --dry-runfailed for one or more packages. That makes the release workflow's dry-run gate unreliable.Suggested fix
-const published = []; -const skipped = []; -const toRetry = []; +const published = []; +const skipped = []; +const toRetry = []; +const finalFailed = []; @@ } catch { // Double-check: the publish might have actually succeeded // (e.g. npm returned non-zero but the package landed) if (!isDryRun && isPublished(pkg.name, pkg.version)) { console.log(` ⏭️ ${label} already published (confirmed after error)`); skipped.push(label); + } else if (isDryRun) { + console.error(` ❌ ${label} dry-run failed`); + finalFailed.push(label); } else { console.error(` ❌ ${label} failed, will retry`); toRetry.push(pkg); } } } // Retry failed packages once -const finalFailed = []; if (toRetry.length > 0 && !isDryRun) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/publish.js` around lines 93 - 109, The catch path currently queues failed packages into toRetry but the retry loop is skipped when isDryRun is true, causing dry-run failures to be ignored; update the catch block handling around isDryRun/isPublished so that when isDryRun is true and the publish attempt throws, the package is added to finalFailed (and an error logged) instead of being silently ignored or queued for retry; reference the variables/functions label, pkg, isDryRun, isPublished, skipped, toRetry, and finalFailed when making this change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 21-27: Update the canonical commands list to include the missing
validation step `ut run site:dev` and explicitly state the mandated validation
order: run `ut run build` → `ut run lint` → `ut run test` → `ut run site:dev`;
ensure the bullet list replaces the current unordered steps with the ordered
sequence and add a brief note that filtered commands (e.g. `ut --filter=egg run
test` or `ut --filter=site run dev`) may be used for focused work but do not
replace the full validation sequence.
In `@packages/egg/README.md`:
- Around line 23-27: Prepend the utoo bootstrap step to the quickstart by
instructing users to run "corepack enable utoo" (which installs utoo v1.0.28)
before any ut commands; update the snippet around the mkdir/npm init/ut commands
(the block that currently shows "npm init egg --type=simple", "ut install", "ut
run dev") to include the corepack enable utoo step first so a clean machine will
have utoo enabled prior to running ut install or ut run dev.
In `@README.md`:
- Around line 29-33: The README code blocks invoking the ut CLI (e.g., sequences
starting with "ut create", "ut install", "ut run dev") are missing the
prerequisite bootstrap step; update each affected code sample (including the
block containing "ut create egg@beta" and the other examples referenced) to
prepend the required command corepack enable utoo (which installs utoo v1.0.28)
before any ut commands so users on a clean machine won't fail before
install/dev/service commands; ensure the explanatory text mentions enabling utoo
first per the project guideline.
---
Outside diff comments:
In `@scripts/publish.js`:
- Around line 93-109: The catch path currently queues failed packages into
toRetry but the retry loop is skipped when isDryRun is true, causing dry-run
failures to be ignored; update the catch block handling around
isDryRun/isPublished so that when isDryRun is true and the publish attempt
throws, the package is added to finalFailed (and an error logged) instead of
being silently ignored or queued for retry; reference the variables/functions
label, pkg, isDryRun, isPublished, skipped, toRetry, and finalFailed when making
this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5b4ceb70-1bb6-4b5a-923c-f3f3ff1b9b7a
📒 Files selected for processing (10)
.github/copilot-instructions.mdAGENTS.mdREADME.mdREADME.zh-CN.mdpackages/egg/README.mdplugins/redis/README.mdscripts/dev-services.jsscripts/publish.jstegg/CLAUDE.mdtools/create-egg/README.md
✅ Files skipped from review due to trivial changes (5)
- plugins/redis/README.md
- scripts/dev-services.js
- README.zh-CN.md
- .github/copilot-instructions.md
- tegg/CLAUDE.md
🚧 Files skipped from review as they are similar to previous changes (1)
- tools/create-egg/README.md
Comment on lines
+21
to
+27
| - `corepack enable utoo` enables the pinned utoo version on a clean machine. | ||
| - `ut install` hydrates the workspace. | ||
| - `ut run build` builds all packages. | ||
| - `ut run test` runs the main test suite. | ||
| - `ut run lint` runs linting. | ||
| - `ut run typecheck` runs TypeScript checking. | ||
| - use filtered commands for focused work, for example `ut --filter=egg run test` or `ut --filter=site run dev`. |
Contributor
There was a problem hiding this comment.
Document the required validation sequence in the canonical command list.
AGENTS.md is the shared source of truth, but this section still omits the required ut run site:dev step and the mandated build → lint → test → site:dev order. Agents following this file will miss repo-required validation.
As per coding guidelines "Run validation steps in sequence after making changes: (1) build all packages with ut run build, (2) run linting with ut run lint, (3) run tests with ut run test, (4) test documentation site with ut run site:dev".
🧰 Tools
🪛 LanguageTool
[style] ~26-~26: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...intruns linting. -ut run typecheck` runs TypeScript checking. - use filtered com...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@AGENTS.md` around lines 21 - 27, Update the canonical commands list to
include the missing validation step `ut run site:dev` and explicitly state the
mandated validation order: run `ut run build` → `ut run lint` → `ut run test` →
`ut run site:dev`; ensure the bullet list replaces the current unordered steps
with the ordered sequence and add a brief note that filtered commands (e.g. `ut
--filter=egg run test` or `ut --filter=site run dev`) may be used for focused
work but do not replace the full validation sequence.
Contributor
Author
There was a problem hiding this comment.
Skipping for this PR — adding a mandated build → lint → test → site:dev validation sequence to AGENTS.md is a new convention beyond the pnpm→utoo rename scope. Happy to land it in a follow-up.
Contributor
There was a problem hiding this comment.
@killagu, that's a fair scope boundary — keeping this PR focused on the rename makes sense. Would you like me to open a GitHub issue to track adding the mandated build → lint → test → site:dev validation sequence to AGENTS.md as a follow-up?
Without an explicit \`version\` input, \`pnpm/action-setup\` reads \`packageManager\` from package.json — which now declares \`utoo@1.0.28\`, not pnpm — and aborts with \`Invalid packageManager field in package.json\`. Pin to \`10\` (matches the prior \`pnpm@10.28.0\` we used) so the pack step bootstraps regardless of the \`packageManager\` value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- .github/copilot-instructions.md: `ut run ci` actually runs tests with coverage only (no build); rewrite description accordingly. Site dev server uses VitePress' default port, not :8000; drop the hard-coded URL. Replace the `cd site && ut run build` invocation with the root `ut run site:build` script. - scripts/utils.js: clarify the workspace-file comment — utoo reads `pnpm-workspace.yaml` as-is, so naming the file matters. - README.md / README.zh-CN.md / packages/egg/README.md: prepend `corepack enable utoo` to the quickstart so clean machines get the pinned utoo before `ut create`/`ut install`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 2, 2026
Closed
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
Comment on lines
74
to
+75
| - name: Install dependencies | ||
| run: pnpm install --no-frozen-lockfile | ||
| run: ut install --from pnpm |
The previous env var \`PNPM_PACKAGE_MANAGER_STRICT\` is not recognized by pnpm, so pnpm kept refusing the pack step with \`This project is configured to use utoo\`. The actual setting is \`package-manager-strict\`, exposed via \`NPM_CONFIG_PACKAGE_MANAGER_STRICT\`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ps resolve \`pnpm -r pack\` needs pnpm's own \`node_modules\` symlink layout to resolve \`workspace:*\` versions; otherwise it errors with \`ERR_PNPM_CANNOT_RESOLVE_WORKSPACE_PROTOCOL\`. Run \`pnpm install --no-frozen-lockfile --ignore-scripts\` first — the packages are already in the global utoo store, so this is cheap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --no-frozen-lockfile | ||
| run: ut install --from pnpm |
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
Comment on lines
+43
to
+47
| addChildren('tools'); | ||
| addChildren('tegg/core'); | ||
| addChildren('tegg/plugin'); | ||
| addChildren('tegg/standalone'); | ||
| return dirs; |
| } | ||
| } | ||
|
|
||
| for (const base of ['packages', 'plugins', 'tools', 'tegg']) { |
Comment on lines
+61
to
+65
| CI splits the test suite across parallel runners via `scripts/run-shard.js` | ||
| (`node scripts/run-shard.js <shard>`). Each heavy fork-based package | ||
| (`cluster`, `egg`, `mock`, `development`, `schedule-a`/`schedule-b`) runs on its | ||
| own runner with a `--maxWorkers` cap so forked egg cluster child processes do | ||
| not oversubscribe the CPU and time out; `rest-a`/`rest-b` split everything else |
Comment on lines
+66
to
+68
| with full parallelism. The goal is to keep each shard's `vitest run` wall time | ||
| under ~60s. To reproduce one shard locally: `node scripts/run-shard.js cluster`. | ||
| Use `node scripts/run-shard.js all` for the unsharded full suite. |
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
Comment on lines
+41
to
+46
| addChildren('packages'); | ||
| addChildren('plugins'); | ||
| addChildren('tools'); | ||
| addChildren('tegg/core'); | ||
| addChildren('tegg/plugin'); | ||
| addChildren('tegg/standalone'); |
Comment on lines
+134
to
+135
| const shardName = argv[0] && !argv[0].startsWith('-') ? argv[0] : 'all'; | ||
| const passthrough = (argv[0] && !argv[0].startsWith('-') ? argv.slice(1) : argv).filter(Boolean); |
Comment on lines
+214
to
+215
| - name: Run tests (shard ${{ matrix.shard }}) | ||
| run: node scripts/run-shard.js ${{ matrix.shard }} -- --coverage |
Comment on lines
+61
to
+66
| CI splits the test suite across parallel runners via `scripts/run-shard.js` | ||
| (`node scripts/run-shard.js <shard>`). Each heavy fork-based package | ||
| (`cluster`, `egg`, `mock`, `development`, `schedule-a`/`schedule-b`) runs on its | ||
| own runner with a `--maxWorkers` cap so forked egg cluster child processes do | ||
| not oversubscribe the CPU and time out; `rest-a`/`rest-b` split everything else | ||
| with full parallelism. The goal is to keep each shard's `vitest run` wall time |
Comment on lines
+65
to
+68
| not oversubscribe the CPU and time out; `rest-a`/`rest-b` split everything else | ||
| with full parallelism. The goal is to keep each shard's `vitest run` wall time | ||
| under ~60s. To reproduce one shard locally: `node scripts/run-shard.js cluster`. | ||
| Use `node scripts/run-shard.js all` for the unsharded full suite. |
Comment on lines
74
to
76
| - name: Install dependencies | ||
| run: pnpm install --no-frozen-lockfile | ||
| run: ut install --from pnpm | ||
|
|
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
Comment on lines
+61
to
+68
| CI splits the test suite across parallel runners via `scripts/run-shard.js` | ||
| (`node scripts/run-shard.js <shard>`). Each heavy fork-based package | ||
| (`cluster`, `egg`, `mock`, `development`, `schedule-a`/`schedule-b`) runs on its | ||
| own runner with a `--maxWorkers` cap so forked egg cluster child processes do | ||
| not oversubscribe the CPU and time out; `rest-a`/`rest-b` split everything else | ||
| with full parallelism. The goal is to keep each shard's `vitest run` wall time | ||
| under ~60s. To reproduce one shard locally: `node scripts/run-shard.js cluster`. | ||
| Use `node scripts/run-shard.js all` for the unsharded full suite. |
Comment on lines
247
to
250
| - name: Run example tests | ||
| if: ${{ matrix.os != 'windows-latest' }} | ||
| # Only run example tests once per (os, node) combo to avoid duplication. | ||
| if: ${{ matrix.os != 'windows-latest' && matrix.shard == 'rest-1' }} | ||
| run: | |
Comment on lines
74
to
+75
| - name: Install dependencies | ||
| run: pnpm install --no-frozen-lockfile | ||
| run: ut install --from pnpm |
|
|
||
| import { escape, getFilepath } from './utils.ts'; | ||
|
|
||
| describe('test/override.test.ts', () => { |
Comment on lines
+63
to
+67
| (`cluster`, `egg`, `mock`, `development`, `schedule-a`/`schedule-b`) runs on its | ||
| own runner with a `--maxWorkers` cap so forked egg cluster child processes do | ||
| not oversubscribe the CPU and time out; `rest-a`/`rest-b` split everything else | ||
| with full parallelism. The goal is to keep each shard's `vitest run` wall time | ||
| under ~60s. To reproduce one shard locally: `node scripts/run-shard.js cluster`. |
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
killagu
force-pushed
the
chore/replace-pnpm-with-utoo
branch
from
e785de1 to
756903c
Compare
fengmk2
approved these changes
Jun 4, 2026
killagu
force-pushed
the
chore/replace-pnpm-with-utoo
branch
from
756903c to
e895a5e
Compare
Comment on lines
+41
to
+47
| addChildren('packages'); | ||
| addChildren('plugins'); | ||
| addChildren('tools'); | ||
| addChildren('tegg/core'); | ||
| addChildren('tegg/plugin'); | ||
| addChildren('tegg/standalone'); | ||
| return dirs; |
Comment on lines
+49
to
+57
| for (const base of ['packages', 'plugins', 'tools', 'tegg']) { | ||
| const abs = path.join(ROOT, base); | ||
| try { | ||
| statSync(abs); | ||
| } catch { | ||
| continue; | ||
| } | ||
| walk(abs); | ||
| } |
Comment on lines
+134
to
+136
| const shardName = argv[0] && !argv[0].startsWith('-') ? argv[0] : 'all'; | ||
| const passthrough = (argv[0] && !argv[0].startsWith('-') ? argv.slice(1) : argv).filter(Boolean); | ||
|
|
Comment on lines
+61
to
+68
| CI splits the test suite across parallel runners via `scripts/run-shard.js` | ||
| (`node scripts/run-shard.js <shard>`). Each heavy fork-based package | ||
| (`cluster`, `egg`, `mock`, `development`, `schedule-a`/`schedule-b`) runs on its | ||
| own runner with a `--maxWorkers` cap so forked egg cluster child processes do | ||
| not oversubscribe the CPU and time out; `rest-a`/`rest-b` split everything else | ||
| with full parallelism. The goal is to keep each shard's `vitest run` wall time | ||
| under ~60s. To reproduce one shard locally: `node scripts/run-shard.js cluster`. | ||
| Use `node scripts/run-shard.js all` for the unsharded full suite. |
|
|
||
| ```bash | ||
| pnpm test | ||
| ut test |
Comment on lines
+13
to
+25
| app = cluster('apps/cluster_mod_sticky', { | ||
| sticky: true, | ||
| port: 17010, | ||
| } as any); | ||
| app.debug(); | ||
| await app.ready(); | ||
| }); | ||
| afterAll(() => app.close()); | ||
|
|
||
| it('should online sticky cluster mode startup success', async () => { | ||
| app.expect('stdout', /app_worker#\d:\d+ started at (?!9500)/); | ||
| app.expect('stdout', /egg started on http:\/\/127.0.0.1:17010/); | ||
| await request('http://127.0.0.1:17010').get('/portal/i.htm').expect('hi cluster').expect(200); |
…st path Cut the monolithic test job (single ~190s vitest run, gated by a 170s cluster file; 12-29min on CI) into parallel, wall-time-balanced shards so every job on the PR critical path stays ≤60s — verified on real CI (48 ubuntu shards run 15-59s). PR critical path = ubuntu only: - Test sharding (scripts/run-shard.js, driven by the CI matrix): fork-heavy packages split via vitest --shard (cluster→3, egg→2, mock→2, schedule→4, security→2, plus redis/multipart/development standalone), each capped with --maxWorkers so forked egg cluster processes don't oversubscribe the CPU; the light remainder greedy bin-packed by per-dir cpu weight into 8 rest-* shards. - Long single test files split by `describe` block (no semantic change, no removed cases) so vitest can parallelize them. - quality split into a parallel matrix (lint/typecheck/fmtcheck/build/site) so the slowest check — not their sum — bounds wall time. - egg-bin runs without --coverage to stay ≤60s (no threshold; report only). macOS/Windows whole-suite compatibility (slow: ~13-25min; macOS has only ~5 runner slots) moved to a `test-compat` job that runs at merge time (merge_group) and on push to next — NOT on pull_request — so it no longer gates the PR wall while still enforcing cross-platform coverage before code lands. CI test jobs on a PR drop from 132 to the 48 ubuntu shards. Latent bugs fixed along the way: - tegg controller ControllerMetaManager.test.ts triggers a duplicate-proto error that polluted the process-global registry under isolate:false, failing sibling files; isolated that project (isolate:true). - clean-dist used `ut run clean --workspaces` which aborts the && chain (root has no clean script) → scripts/clean-dist.js. - typecheck/pretest used `ut run <self> --workspaces`, which includes the root and recurses infinitely → scripts/run-workspaces.js (concurrent, root-bin PATH). - Windows runner images no longer set %HOME%, breaking egg_loader getHomedir; export HOME=%USERPROFILE% on the windows compat job. Windows flakes absorbed by --retry. No test semantics changed or cases removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
killagu
force-pushed
the
chore/replace-pnpm-with-utoo
branch
from
e895a5e to
2a5ba86
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpmwithutooacross docs, top-level scripts, and CI workflows so the repo guidance matches the package manager the project actually uses.packageManagerinpackage.jsontoutoo@1.0.28; switchscripts/{publish,version,utils}.jsto invokeutoo(and align their comments)..github/workflows/release.ymland.github/workflows/e2e-test.yml, swappnpm/action-setupforutooland/setup-utooand callut/utoo(mirroring the pattern already used byci.yml).pnpm-lock.yaml,pnpm-workspace.yaml) and the CLI argument value inut install --from pnpm— those reference real artifacts on disk and a flag value, not tool invocations.CHANGELOG.mdentries, source code that detects pnpmnode_moduleslayouts (packages/core/src/loader/*), and theplugin-pnpm*test fixtures.Test plan
nextfor typecheck, build, lint, format check, and tests.release.yml(workflow_dispatch dry-run) completes through install + build usingut install --from pnpmandut run build.e2e-test.ymlsucceeds end-to-end; in particular confirmPUBLINT_PACK: utoois accepted bypublint— if not, revert that env var tonpmand keep the rest.🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation