Make CI actually run, and go green - #9
Merged
Conversation
The default branch is master, so the push and pull_request triggers in code_style, code_test and docs_build never matched and no checks ran. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
eggzec/brayer is not activated on Codecov, so the upload returns HTTP 404 "Repository not found" and fail_ci_if_error turned that into a failure of every matrix job even though the suite passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The lock pinned pydantic 2.11.7, whose pydantic-core 2.33.2 publishes no cp314 wheel. On 3.14 uv fell back to building it from source, and that build fails: pydantic-core 2.33.2 uses PyO3 0.24.1, which supports at most Python 3.13. pydantic-core 2.46.4 ships cp314 wheels for every matrix platform, so nothing is built from source. Suite passes locally: 130 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI had never executed on this repository —
gh run list --workflow=code_test.ymlshowed zero runs before this branch. Fixing that surfaced two further failures that the first bug had been hiding. Three fixes, each uncovered by the one before it:1. Workflows never triggered (
3caeeb8)The default branch is
master, butpush/pull_requesttriggers incode_style.yml,code_test.ymlanddocs_build.ymlwere filtered tomain, which does not exist here. No event ever matched.2. Codecov failed the whole matrix (
74734f5)With CI finally running, every
testingjob passed its suite and then died on the upload step:eggzec/brayeris not activated on Codecov and there is noCODECOV_TOKENsecret, sofail_ci_if_error: trueturned a reporting outage into a build failure. Coverage upload is now best-effort; the test run is the gate.3. Python 3.14 could not install dependencies (
c20dd43)All three 3.14 jobs failed before running any test:
uv.lockpinnedpydantic 2.11.7→pydantic-core 2.33.2, which ships no cp314 wheel, so uv built it from source and hit that version's PyO3 ceiling.pyproject.tomlonly requirespydantic>=2.7, so the stale lock was the only constraint. Relocked topydantic 2.13.4/pydantic-core 2.46.4, which publishes cp314 wheels for every matrix platform.Test plan
setup,fresh_build / build, and Build Documentation.paths: ['**/*.py']filter excludes this PR, which touches no Python.Follow-up (not in this PR)
To get coverage data flowing again, activate
eggzec/brayerat codecov.io..codecov.yml(90% project / 70% patch) and the README badge are already in place and will start working once onboarded.🤖 Generated with Claude Code