Skip to content

Make CI actually run, and go green - #9

Merged
saudzahirr merged 3 commits into
masterfrom
fix/ci-branch-triggers
Aug 25, 2026
Merged

Make CI actually run, and go green#9
saudzahirr merged 3 commits into
masterfrom
fix/ci-branch-triggers

Conversation

@saudzahirr

@saudzahirr saudzahirr commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

CI had never executed on this repository — gh run list --workflow=code_test.yml showed zero runs before this branch. Fixing that surfaced two further failures that the first bug had been hiding. Three fixes, each uncovered by the one before it:

1. Workflows never triggered (3caeeb8)
The default branch is master, but push/pull_request triggers in code_style.yml, code_test.yml and docs_build.yml were filtered to main, which does not exist here. No event ever matched.

2. Codecov failed the whole matrix (74734f5)
With CI finally running, every testing job passed its suite and then died on the upload step:

error -- Upload queued for processing failed: {"message":"Repository not found"}  (HTTP 404)

eggzec/brayer is not activated on Codecov and there is no CODECOV_TOKEN secret, so fail_ci_if_error: true turned a reporting outage into a build failure. Coverage upload is now best-effort; the test run is the gate.

3. Python 3.14 could not install dependencies (c20dd43)
All three 3.14 jobs failed before running any test:

error: the configured Python interpreter version (3.14) is newer than
       PyO3's maximum supported version (3.13)
       Current version: 0.24.1

uv.lock pinned pydantic 2.11.7pydantic-core 2.33.2, which ships no cp314 wheel, so uv built it from source and hit that version's PyO3 ceiling. pyproject.toml only requires pydantic>=2.7, so the stale lock was the only constraint. Relocked to pydantic 2.13.4 / pydantic-core 2.46.4, which publishes cp314 wheels for every matrix platform.

Test plan

  • All 12 checks pass on this PR: the full 9-job matrix (3.10–3.14 across ubuntu/windows/macos), setup, fresh_build / build, and Build Documentation.
  • Suite run locally against the upgraded pydantic: 130 passed.
  • Lint and Format is correctly absent — its paths: ['**/*.py'] filter excludes this PR, which touches no Python.

Follow-up (not in this PR)

To get coverage data flowing again, activate eggzec/brayer at codecov.io. .codecov.yml (90% project / 70% patch) and the README badge are already in place and will start working once onboarded.

🤖 Generated with Claude Code

saudzahirr and others added 3 commits August 25, 2026 15:20
The default branch is master, so the push and pull_request triggers in
code_style, code_test and docs_build never matched and no checks ran.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
eggzec/brayer is not activated on Codecov, so the upload returns
HTTP 404 "Repository not found" and fail_ci_if_error turned that into
a failure of every matrix job even though the suite passed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The lock pinned pydantic 2.11.7, whose pydantic-core 2.33.2 publishes no
cp314 wheel. On 3.14 uv fell back to building it from source, and that
build fails: pydantic-core 2.33.2 uses PyO3 0.24.1, which supports at
most Python 3.13.

pydantic-core 2.46.4 ships cp314 wheels for every matrix platform, so
nothing is built from source. Suite passes locally: 130 passed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@saudzahirr saudzahirr changed the title Trigger CI workflows on master instead of main Make CI actually run, and go green Aug 25, 2026
@saudzahirr
saudzahirr merged commit 2d59156 into master Aug 25, 2026
13 checks passed
@saudzahirr
saudzahirr deleted the fix/ci-branch-triggers branch August 25, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant