Add Arctis Nova Pro Omni support - #49
Open
Cisien wants to merge 2 commits into
Open
Conversation
Cisien
force-pushed
the
develop
branch
6 times, most recently
from
July 15, 2026 23:09
07647d5 to
6c90ffd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Arctis Nova Pro Omni along with some fixes for the GUI that prevented rendering device settings.
The first fix was a race condition where the incorrect cached dbus proxy could be used leading to an exception that was logged and swallowed.
The second fix is directly related to the sheer number of configuration options of the Omni. This fix adds a scroll area so the setting widgets can scroll instead of collapsing to 0-height and appearing to not render.
I have been able to verify that all settings exposed for this headset appear to work. I don't have any other Arctis headsets available to test with, so I can't verify if this change causes problems with those devices.
AI Disclaimer: I did leverage AI (Codex, gpt-5.6-terra) to help discover the device HID protocol and to implement the change in this PR. I have fully reviewed and tested these changes on my local machine.
Edit: I noticed that there was a cleaner way to render the various time selections that showed up for screen saver timeout and bluetooth auto-off time, and converted those to a drop-down, which also fixed an issue with a horizontal scrollbar showing up in the Device panel.