Fix Nova Pro Wireless hardware EQ initialization - #64
Conversation
|
@elegos This was tested on an Arctis Nova Pro Wireless (1038:12e0), including daemon restarts, all hardware EQ presets, ChatMix, and a comparison with current SteelSeries GG USB traffic. A review would be appreciated when you have time. |
0e4fc67 to
172645c
Compare
|
Follow-up hardware test for commit 172645c: after restoring every previous initialization command except the three 0x3b variants, rebuilding, reinstalling, and restarting the daemon, the base station remains in PRESET and restores the selected hardware EQ preset correctly. The daemon also initializes the device and Media/Chat sinks without errors. |
|
Hey Hello @Gabbajoe , thanks for the submission :) We're currently in beta phase for a release (2.5.0), we're in feature freeze, and after 2.5.0 will come version 3.0.0, a rewriting of the service in rust, which already includes the hardware EQ presets! If you want to use the hardware preset right now, it'd be better to use your fork for a while, or uninstall LAM and compile and install (via Makefile) the feature/v3 branch (it currently works on the Nova Pro Wireless only, at the moment, while the last feature (VC) is being added)! The rust rewrite will have some nice additions, besides hardware EQ 😃 |
|
Thanks for the explanation! I understand the feature freeze and that hardware EQ support is already part of the v3 rewrite.\n\nOne part of this PR is independent of the new UI and appears to be a bug in the current 2.5 branch: the Nova Pro Wireless initialization sends command 06 3b three times, which forces the base station's hardware EQ selector into an undocumented SONAR state.\n\nWould you accept a separate minimal bugfix PR that only removes those three 0x3b commands? I can keep the hardware EQ UI changes in my fork and also test the feature/v3 branch on the device. |
Summary
Fix the Arctis Nova Pro Wireless initialization so that starting the daemon no longer forces the base station's hardware EQ selector into the undocumented SONAR state.
Add UI controls for ChatMix, the Sonar station icon, and all hardware EQ presets supported by the base station.
Root cause
The previous initialization sequence contained the undocumented command
06 3b. Hardware testing confirmed that this command forces the base station's EQ selector from PRESET into SONAR.A USBPcap capture of the current SteelSeries GG software showed that normal Sonar operation uses
06 8dfor the station icon and06 49for ChatMix, while the hardware EQ remains in PRESET mode. Current GG does not send06 3bwhen enabling Sonar.Scope
06 3bvariants that were confirmed to causethe unwanted state. All other existing initialization commands are retained
because their purpose and relevance to other device functions or firmware
versions has not yet been established.
Changes
06 09.Testing
Tested with an Arctis Nova Pro Wireless, USB ID
1038:12e0.