fix(XSender): upgrade x-sender to 1.4.3 to fix IME input bugs - #496
Open
stevenwangking wants to merge 1 commit into
Open
fix(XSender): upgrade x-sender to 1.4.3 to fix IME input bugs#496stevenwangking wants to merge 1 commit into
stevenwangking wants to merge 1 commit into
Conversation
x-sender 1.3.3 has critical IME (Input Method Editor) bugs that affect Chinese/Japanese/Korean users. Upgrade to 1.4.3 which includes the compositionUpdate fix introduced in 1.3.9. Related issues: - element-plus-x#488 (iOS cannot input Chinese) - x-sender#45 (iOS pinyin fast input causes input freeze) - x-sender#44 (Chinese IME outputs latin letters)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Upgrade
x-senderfrom1.3.3to1.4.3to fix critical IME (Input Method Editor) bugs that affect Chinese/Japanese/Korean users.🔗 Related Issues
📝 Problem Description
x-sender@1.3.3does not handlecompositionstart/compositionUpdate/compositionendevents, causing:The fix (
compositionUpdatehandling) was introduced inx-sender@1.3.9. This PR upgrades to1.4.3(latest stable).📋 Changes
packages/core/package.json:x-sender^1.3.3 → ^1.4.3pnpm-lock.yaml: updated accordingly✅ API Compatibility
Verified that the API changes between 1.3.3 and 1.4.3 do NOT affect Element-Plus-X:
backspace?: booleanadded to TipConfigEVENT_COMMON_SELECT_ACTIVE→EVENT_COMMON_TAG_CLICKEVENT_COMMON_TAG_CLICKnew exportElement-Plus-X only imports
XSenderdefault export and types (MentionConfig,TriggerConfig,SelectConfig,TipConfig,TagData, etc.) — none of which are affected.🧪 Verification
x-sender@1.3.3vs1.4.3: onlyXSender.mjschanged (CSS and type declarations nearly identical)vue-element-plus-xwith new version: all components identical exceptdist/es/XSender/index.js(expected)📝 变更类型