Skip to content

UpdatesView is a dialog #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danirabbit wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −24
Draft

UpdatesView is a dialog #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c3aabd
UpdatesView is a dialog
danirabbit Aug 7, 2026
a4baa6b
Fix navigation
danirabbit Aug 7, 2026
f8954d3
Double click activate
danirabbit Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class AppCenter.MainWindow : Gtk.ApplicationWindow {
// Launchable package set when installed
private AppCenterCore.Package? last_installed_package;

private Views.AppListUpdateView installed_view;
private UpdatesDialog installed_view;

public MainWindow (Gtk.Application app) {
Object (application: app);
Expand Down Expand Up @@ -72,7 +72,11 @@ public class AppCenter.MainWindow : Gtk.ApplicationWindow {

var homepage = new Homepage ();

installed_view = new Views.AppListUpdateView ();
installed_view = new UpdatesDialog () {
modal = true,
transient_for = this
};
installed_view.navigate.connect ((uid) => activate_action_variant (MainWindow.ACTION_PREFIX + MainWindow.ACTION_SHOW_PACKAGE, uid));

navigation_view = new Adw.NavigationView ();
navigation_view.add (homepage);
Expand Down Expand Up @@ -196,11 +200,7 @@ public class AppCenter.MainWindow : Gtk.ApplicationWindow {
}

public void go_to_installed () {
if (installed_view.parent != null) {
navigation_view.pop_to_page (installed_view);
} else {
navigation_view.push (installed_view);
}
installed_view.present ();
}

public void search (string term = "", bool mimetype = false) {
Expand Down
35 changes: 18 additions & 17 deletions src/Views/AppListUpdateView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@

/** AppList for the Updates View. Sorts update_available first and shows headers.
* Does not show Uninstall Button **/
public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {
public class AppCenter.UpdatesDialog : Gtk.ApplicationWindow {
public signal void navigate (string uid);

private Gtk.FlowBox installed_flowbox;
private Gtk.ListBox list_box;
private Granite.HeaderLabel installed_header;
Expand All @@ -17,6 +19,8 @@ public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {
private uint updated_label_timeout_id = 0;

construct {
application = (Gtk.Application) GLib.Application.get_default ();

var update_manager = AppCenterCore.UpdateManager.get_default ();
unowned var flatpak_backend = AppCenterCore.FlatpakBackend.get_default ();

Expand Down Expand Up @@ -62,7 +66,6 @@ public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {
updatable_header.append (update_all_button);

list_box = new Gtk.ListBox () {
activate_on_single_click = true,
hexpand = true,
};
list_box.bind_model (flatpak_backend.updatable_packages, create_row_from_package);
Expand All @@ -78,7 +81,6 @@ public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {
};

var in_progress_list = new Gtk.ListBox () {
activate_on_single_click = true,
hexpand = true,
};
in_progress_list.bind_model (flatpak_backend.working_packages, create_row_from_package);
Expand All @@ -99,6 +101,7 @@ public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {
);

installed_flowbox = new Gtk.FlowBox () {
activate_on_single_click = false,
column_spacing = 24,
max_children_per_line = 5,
row_spacing = 12
Expand All @@ -117,7 +120,7 @@ public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {

var clamp = new Adw.Clamp () {
child = box,
maximum_size = AppInfoView.MAX_WIDTH,
maximum_size = Views.AppInfoView.MAX_WIDTH,
};

var scrolled = new Gtk.ScrolledWindow () {
Expand Down Expand Up @@ -154,51 +157,49 @@ public class AppCenter.Views.AppListUpdateView : Adw.NavigationPage {
menu_popover.add_css_class (Granite.STYLE_CLASS_MENU);

var menu_button = new Gtk.MenuButton () {
icon_name = "open-menu",
icon_name = "open-menu-symbolic",
popover = menu_popover,
primary = true,
tooltip_markup = ("%s\n" + Granite.TOOLTIP_SECONDARY_TEXT_MARKUP).printf (
_("Settings"),
"F10"
)
};
menu_button.add_css_class (Granite.STYLE_CLASS_LARGE_ICONS);

var search_button = new Gtk.Button.from_icon_name ("edit-find") {
action_name = "win.search",
/// TRANSLATORS: the action of searching
tooltip_text = C_("action", "Search")
};
search_button.add_css_class (Granite.STYLE_CLASS_LARGE_ICONS);

var headerbar = new Gtk.HeaderBar () {
title_widget = new Gtk.Grid () { visible = false }
};
headerbar.pack_start (new BackButton ());
headerbar.pack_end (menu_button);
headerbar.pack_end (search_button);

var toolbarview = new Adw.ToolbarView () {
content = scrolled
};
toolbarview.add_top_bar (headerbar);
toolbarview.add_css_class (Granite.STYLE_CLASS_VIEW);

titlebar = new Gtk.Grid () { visible = false };
child = toolbarview;
hide_on_close = true;
/// TRANSLATORS: the name of the Installed Apps view
title = C_("view", "Installed");
default_height = 600;
default_width = 400;

@danirabbit danirabbit Aug 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to be wider. Some apps have long names or version numbers

height_request = 400;
add_css_class ("dialog");

list_box.row_activated.connect ((row) => {
if (row.get_child () is Widgets.InstalledPackageRowGrid) {
var package = ((Widgets.InstalledPackageRowGrid) row.get_child ()).package;
activate_action_variant (MainWindow.ACTION_PREFIX + MainWindow.ACTION_SHOW_PACKAGE, package.uid);
navigate (package.uid);
close ();
}
});

installed_flowbox.child_activated.connect ((child) => {
if (child.get_child () is Widgets.InstalledPackageRowGrid) {
var package = ((Widgets.InstalledPackageRowGrid) child.get_child ()).package;
activate_action_variant (MainWindow.ACTION_PREFIX + MainWindow.ACTION_SHOW_PACKAGE, package.uid);
navigate (package.uid);
close ();
}
});

Expand Down