Skip to content

Port to GTK4 - #29

Merged
ryonakano merged 18 commits into
mainfrom
danirabbit/gtk4
Aug 24, 2026
Merged

Port to GTK4#29
ryonakano merged 18 commits into
mainfrom
danirabbit/gtk4

Conversation

@danirabbit

Copy link
Copy Markdown
Member

Fixes #8

@danirabbit danirabbit moved this to In progress in OS 8.1.0 Jun 30, 2025
@danirabbit danirabbit removed this from OS 8.1.0 Oct 3, 2025
@danirabbit danirabbit moved this to In Progress in GTK4 Porting Apr 15, 2026
@zeebok

This comment was marked as outdated.

@danirabbit

This comment was marked as outdated.

Comment thread src/Dialog/ReceiverDialog.vala Outdated
Comment thread src/Dialog/SenderDialog.vala Outdated
@danirabbit
danirabbit requested a review from ryonakano August 18, 2026 16:29
@danirabbit

Copy link
Copy Markdown
Member Author

@ryonakano think I fixed this how it's supposed to be. We set hide_on_close property based on the status change of transfer and then call close instead of destroy

@danirabbit
danirabbit marked this pull request as ready for review August 18, 2026 17:50
Comment thread src/Dialog/SenderDialog.vala
Comment thread src/Application.vala Outdated
Comment thread src/Dialog/ScanDialog.vala
@danirabbit
danirabbit requested a review from ryonakano August 21, 2026 16:22
@danirabbit

Copy link
Copy Markdown
Member Author

@ryonakano I think I resolved all your concerns :)

@ryonakano ryonakano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@danirabbit danirabbit mentioned this pull request Aug 24, 2026
@ryonakano ryonakano added this to OS 9 Aug 24, 2026
@ryonakano ryonakano moved this to Needs Review in OS 9 Aug 24, 2026
@ryonakano ryonakano moved this from In Progress to Needs Review in GTK4 Porting Aug 24, 2026
@ryonakano
ryonakano merged commit 50e9432 into main Aug 24, 2026
4 checks passed
@ryonakano
ryonakano deleted the danirabbit/gtk4 branch August 24, 2026 22:43
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Aug 24, 2026
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Port to GTK 4

3 participants