Skip to content

Fix compilation errors on new Vala - #304

Merged
danirabbit merged 2 commits into
mainfrom
lenemter/fix-errors
Aug 30, 2026
Merged

Fix compilation errors on new Vala#304
danirabbit merged 2 commits into
mainfrom
lenemter/fix-errors

Conversation

@lenemter

Copy link
Copy Markdown
Member
../src/Services/DBusInterfaces/Device.vala:45:44-45:60: error: `owned' accessor not allowed for specified property type
   45 |         public abstract bool has_history { public owned get; public set; }
      |                                            ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:46:47-46:63: error: `owned' accessor not allowed for specified property type
   46 |         public abstract bool has_statistics { public owned get; public set; }
      |                                               ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:47:43-47:59: error: `owned' accessor not allowed for specified property type
   47 |         public abstract bool is_present { public owned get; public set; }
      |                                           ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:48:48-48:64: error: `owned' accessor not allowed for specified property type
   48 |         public abstract bool is_rechargeable { public owned get; public set; }
      |                                                ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:49:39-49:55: error: `owned' accessor not allowed for specified property type
   49 |         public abstract bool online { public owned get; public set; }
      |                                       ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:50:45-50:61: error: `owned' accessor not allowed for specified property type
   50 |         public abstract bool power_supply { public owned get; public set; }
      |                                             ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:51:43-51:59: error: `owned' accessor not allowed for specified property type
   51 |         public abstract double capacity { public owned get; public set; }
      |                                           ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:52:41-52:57: error: `owned' accessor not allowed for specified property type
   52 |         public abstract double energy { public owned get; public set; }
      |                                         ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:53:47-53:63: error: `owned' accessor not allowed for specified property type
   53 |         public abstract double energy_empty { public owned get; public set; }
      |                                               ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:54:46-54:62: error: `owned' accessor not allowed for specified property type
   54 |         public abstract double energy_full { public owned get; public set; }
      |                                              ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:55:53-55:69: error: `owned' accessor not allowed for specified property type
   55 |         public abstract double energy_full_design { public owned get; public set; }
      |                                                     ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:56:46-56:62: error: `owned' accessor not allowed for specified property type
   56 |         public abstract double energy_rate { public owned get; public set; }
      |                                              ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:57:45-57:61: error: `owned' accessor not allowed for specified property type
   57 |         public abstract double luminosity { public owned get; public set; }
      |                                             ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:58:45-58:61: error: `owned' accessor not allowed for specified property type
   58 |         public abstract double percentage { public owned get; public set; }
      |                                             ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:59:46-59:62: error: `owned' accessor not allowed for specified property type
   59 |         public abstract double temperature { public owned get; public set; }
      |                                              ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:60:42-60:58: error: `owned' accessor not allowed for specified property type
   60 |         public abstract double voltage { public owned get; public set; }
      |                                          ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:61:47-61:63: error: `owned' accessor not allowed for specified property type
   61 |         public abstract int64 time_to_empty { public owned get; public set; }
      |                                               ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:62:46-62:62: error: `owned' accessor not allowed for specified property type
   62 |         public abstract int64 time_to_full { public owned get; public set; }
      |                                              ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:67:48-67:57: error: `owned' accessor not allowed for specified property type
   67 |         public abstract uint32 battery_level { owned get; }
      |                                                ^~~~~~~~~~  
../src/Services/DBusInterfaces/Device.vala:68:40-68:56: error: `owned' accessor not allowed for specified property type
   68 |         public abstract uint32 state { public owned get; public set; }
      |                                        ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:69:45-69:61: error: `owned' accessor not allowed for specified property type
   69 |         public abstract uint32 technology { public owned get; public set; }
      |                                             ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:70:39-70:55: error: `owned' accessor not allowed for specified property type
   70 |         public abstract uint32 Type { public owned get; public set; }
      |                                       ^~~~~~~~~~~~~~~~~              
../src/Services/DBusInterfaces/Device.vala:71:46-71:62: error: `owned' accessor not allowed for specified property type
   71 |         public abstract uint64 update_time { public owned get; public set; }
      |                                              ^~~~~~~~~~~~~~~~~              
Compilation failed: 23 error(s), 3 warning(s)

@lenemter
lenemter requested a review from a team August 30, 2026 08:24

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why owned in the first place

@jeremypw

Copy link
Copy Markdown
Contributor

CI needs fixing.

@danirabbit
danirabbit enabled auto-merge (squash) August 30, 2026 13:40
@danirabbit
danirabbit merged commit f8baf7a into main Aug 30, 2026
2 of 4 checks passed
@danirabbit
danirabbit deleted the lenemter/fix-errors branch August 30, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants