Make Header::bytes_per_row() public#55
Merged
Merged
Conversation
rfuest
requested changes
Apr 28, 2026
rfuest
left a comment
rfuest
left a comment
Member
There was a problem hiding this comment.
Looks good, expect for a few documentation nits.
This is essential information for the user when walking through the bytes themselves. The original crate-private function is kept with the `_uncompressed` suffix. The new public one returns an `Option`.
Contributor
Author
|
I force-pushed, only changing the comments and the test code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping out with tinybmp development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public APIrustfmton the projectjust build(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
Access to
Header::bytes_per_row()is essential information when you want to walk through the bytes yourself. This is my use case on desktop, trying to performantly update a 20-to-60-MiB .bmp file with a solid color regularly. See also commit messages.