deprecate target action support action handler action support etc#21517
Open
NullVoxPopuli wants to merge 9 commits into
Open
deprecate target action support action handler action support etc#21517NullVoxPopuli wants to merge 9 commits into
NullVoxPopuli wants to merge 9 commits into
Conversation
Implements emberjs/rfcs#1041: deprecates TargetActionSupport#triggerAction, ActionHandler#send, and ActionSupport#send under the single deprecation id deprecate-target-action-support, staged as available (not yet enabled) since the RFC is at the Accepted stage. Co-authored-by: Peter Wagenet <peter@wagenet.us>
… into nvp/deprecate-target-action-support-action-handler-action-support-etc
Contributor
📊 Size reportTarball size — dist/dev 0.06%↑
dist/prod 0.06%↑
smoke-tests/v2-app-template/dist 0.2%↑
smoke-tests/v2-app-hello-world-template/dist 0%↑
🤖 This report was automatically generated by wyvox/pkg-size |
This reverts commit 3ad67df.
kategengler
reviewed
Jul 24, 2026
Co-authored-by: Katie Gengler <katie@kmg.io>
…pport.ts Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Draft
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates TargetActionSupport
RFC:
Advancement:
"Deprecate TargetActionSupport"to Stage Ready for Release rfcs#1126Supersedes
History
init, but this is insufficient, as it flags our own internal usage (from classic@ember/component)Note
it's at this point I realize that these mixins are all private and can't actually be imported by users
so the bots initial strategy of deprecating the specific send/trigger methods is the right way to go for now
Important
Previous use of these mixins was available through the
Emberglobal, or barrel-import -- which we've removed.