Fix compiler error when exporting integers while emitting tsd#26590
Open
jeremy-code wants to merge 1 commit into
Open
Fix compiler error when exporting integers while emitting tsd#26590jeremy-code wants to merge 1 commit into
jeremy-code wants to merge 1 commit into
Conversation
Collaborator
|
Looks like you need to use different quotes on the inside and outside here. Also, can out add a test. @brendandahl would likely know where best to add this. |
Collaborator
|
Adding a test here would be good. |
Collaborator
|
Did you mean to close this out? |
sbc100
reviewed
Apr 18, 2026
| self.get_cflags()) | ||
| self.assertFileContents(test_file('other/test_emit_tsd_integer.d.ts'), read_file('test_emit_tsd_integer.d.ts')) | ||
| cmd = shared.get_npm_cmd('tsc') + [test_file('other/test_tsd_integer.ts'), '--noEmit'] | ||
| shared.check_call(cmd) |
Collaborator
There was a problem hiding this comment.
Can we maybe just add an integer to one of the existing tests?
Collaborator
|
Also, could you update the PR title so it clear what area of the codebase this effect? Perhaps something like "Fix ?? error/crash in td.d generation" |
jeremy-code
changed the title
- Fixes emscripten-core#26589 - Replaces concatenation (which can error when snippet is an int) with f-string - Update test_other.py to include POINTER_SIZE
sbc100
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces concatenation (which can error when snippet is an int) with f-string
Fixes: #26589