Skip to content

revert: DEVEX-1653 rt_mode addition — main-path tag-and-release skipped#140

Merged
pdodgen-revparts merged 1 commit into
mainfrom
revert-devex-1653-rt-mode
Jul 1, 2026
Merged

revert: DEVEX-1653 rt_mode addition — main-path tag-and-release skipped#140
pdodgen-revparts merged 1 commit into
mainfrom
revert-devex-1653-rt-mode

Conversation

@pdodgen-revparts

Copy link
Copy Markdown
Contributor

Reverts #137.

Why

After merge of #137 and Batch 1 Phase 3 PRs (license_api, internal_api, rp_api, catalog_api, vin_decoder_service), all four main-builds that went through the shared build-php-v1 orchestrator FAILED at integration-deploy with empty image_tag → helm YAML crash.

Root cause: Github Tag and Release job was SKIPPED on all runs. Its condition if: \${{ !inputs.rt_mode }} should evaluate true when rt_mode isn't set by the caller, but empirically it's evaluating differently. Calculate Build Tag (same condition) DID run, so this is likely an interaction between the needs: [build] chain (with reusable-workflow matrix) and the untyped rt_mode input.

Reverting to unblock the 4 red main-builds (integration environment redeploys will run once next push lands on each app's main). Fix-forward under a fresh PR: add type: boolean, default: false to rt_mode, and verify tag-and-release fires on a canary before re-merging.

Refs DEVEX-1653.

@pdodgen-revparts pdodgen-revparts requested a review from a team as a code owner July 1, 2026 18:23
@cursor

cursor Bot commented Jul 1, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Restores a known-good release path but drops release-train tagging until a fix-forward PR reintroduces rt_mode with a typed boolean default.

Overview
Reverts the DEVEX-1653 rt_mode fork in the reusable build-php-v1 workflow so main-line PHP builds again run Calculate Build Tag → matrix build → Github Tag and Release without conditional skips.

Removes the rt_mode input, the compute-rt-tag job (encodium/actions _compute-rt-tag), and the always() / dual-output wiring that chose between dry-run mathieudutour and RT tags. build now only needs: [calculate-tag] and tags images from that job; workflow tag output comes solely from tag-and-release again.

This unblocks failures where tag-and-release was skipped, leaving an empty image_tag and breaking integration deploy / Helm.

Reviewed by Cursor Bugbot for commit b33ab4d. Bugbot is set up for automated code reviews on this repo. Configure here.

@pdodgen-revparts pdodgen-revparts merged commit 93764cf into main Jul 1, 2026
2 checks passed
@pdodgen-revparts pdodgen-revparts deleted the revert-devex-1653-rt-mode branch July 1, 2026 18:24
pdodgen-revparts added a commit that referenced this pull request Jul 1, 2026
DEVEX-1653: add rt_mode to build-php-v1 orchestrator (transitive-skip fix)

Adds the rt_mode boolean input plus rt-path jobs (compute-rt-tag, gated
build execution) to enable Template A callers to route through the
_compute-rt-tag composite in encodium/actions.

Fixes the transitive-skip cascade discovered when merging Batch 1
Template A PRs immediately post-#137: tag-and-release has `needs: [build]`,
and build's own needs include compute-rt-tag (skipped on main-path).
GitHub Actions' default `success()` gate on job-if propagates that
transitive skipped-status through the needs chain, silently skipping
tag-and-release even when build itself succeeded — resulting in empty
image_tag output → downstream integration-deploy helm apply crashing on
malformed YAML (`image: ghcr.io/…:` with nothing after the colon).

Fix: gate tag-and-release with `if: !cancelled() && !inputs.rt_mode`.
!cancelled() explicitly overrides the implicit success() gate on the
transitive skipped need, restoring the intended semantics: run whenever
the workflow wasn't cancelled AND we're on the non-rt path. Verified
against license_api/rp_api/catalog_api/vin_decoder_service post-merge
canary before Batches 3/4 landed.

Refs DEVEX-1653, #137 (original), #140 (revert).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant