revert: DEVEX-1653 rt_mode addition — main-path tag-and-release skipped#140
Conversation
This reverts commit 0b0684f.
PR SummaryMedium Risk Overview Removes the This unblocks failures where Reviewed by Cursor Bugbot for commit b33ab4d. Bugbot is set up for automated code reviews on this repo. Configure here. |
DEVEX-1653: add rt_mode to build-php-v1 orchestrator (transitive-skip fix) Adds the rt_mode boolean input plus rt-path jobs (compute-rt-tag, gated build execution) to enable Template A callers to route through the _compute-rt-tag composite in encodium/actions. Fixes the transitive-skip cascade discovered when merging Batch 1 Template A PRs immediately post-#137: tag-and-release has `needs: [build]`, and build's own needs include compute-rt-tag (skipped on main-path). GitHub Actions' default `success()` gate on job-if propagates that transitive skipped-status through the needs chain, silently skipping tag-and-release even when build itself succeeded — resulting in empty image_tag output → downstream integration-deploy helm apply crashing on malformed YAML (`image: ghcr.io/…:` with nothing after the colon). Fix: gate tag-and-release with `if: !cancelled() && !inputs.rt_mode`. !cancelled() explicitly overrides the implicit success() gate on the transitive skipped need, restoring the intended semantics: run whenever the workflow wasn't cancelled AND we're on the non-rt path. Verified against license_api/rp_api/catalog_api/vin_decoder_service post-merge canary before Batches 3/4 landed. Refs DEVEX-1653, #137 (original), #140 (revert).
Reverts #137.
Why
After merge of #137 and Batch 1 Phase 3 PRs (license_api, internal_api, rp_api, catalog_api, vin_decoder_service), all four main-builds that went through the shared build-php-v1 orchestrator FAILED at integration-deploy with empty image_tag → helm YAML crash.
Root cause:
Github Tag and Releasejob was SKIPPED on all runs. Its conditionif: \${{ !inputs.rt_mode }}should evaluate true when rt_mode isn't set by the caller, but empirically it's evaluating differently.Calculate Build Tag(same condition) DID run, so this is likely an interaction between theneeds: [build]chain (with reusable-workflow matrix) and the untyped rt_mode input.Reverting to unblock the 4 red main-builds (integration environment redeploys will run once next push lands on each app's main). Fix-forward under a fresh PR: add
type: boolean, default: falseto rt_mode, and verify tag-and-release fires on a canary before re-merging.Refs DEVEX-1653.