Skip to content

Detect click/pop discontinuities with bounded PCM evidence - #13

Open
9o6 wants to merge 1 commit into
engkimo:mainfrom
9o6:fix/issue-4-click-pop
Open

Detect click/pop discontinuities with bounded PCM evidence#13
9o6 wants to merge 1 commit into
engkimo:mainfrom
9o6:fix/issue-4-click-pop

Conversation

@9o6

@9o6 9o6 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Closes #4

Summary

  • add a deterministic PCM16 adjacent-sample discontinuity detector across chunk boundaries
  • preserve stage media time separately from wall-clock event time and deduplicate adjacent detections
  • project bounded incidents with optional nearby queue-clear/barge-in evidence and an explicit remote playout boundary
  • document the detector contract, thresholds, silence handling, and proof limitations

Testing

  • python3 -m ruff check src/voxbench/observability/observer.py src/voxbench/observability/__init__.py src/voxbench/control_plane/run_api.py tests/test_observability.py
  • python3 -m pytest -q (330 passed, 4 skipped)

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 17ac0773-59bd-4350-ba31-a284789b84a3


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect click/pop discontinuities and correlate them with playback events

1 participant